You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/15 22:03:15 UTC
Re: Review Request 41962: Add test for ContainerLogger recovery after
agent failover.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 1:03 p.m.)
Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Changes
-------
Move the mock expectation for `MockContainerLogger*` to before the containerizer is created, i.e. before `MockContainerLogger*` is `Owned<...>` by the containerizer.
Update test due to addition of `Provisioner` to the MesosContainerizer.
Summary (updated)
-----------------
Add test for ContainerLogger recovery after agent failover.
Bugs: MESOS-4150
https://issues.apache.org/jira/browse/MESOS-4150
Repository: mesos
Description (updated)
-------
Add test for ContainerLogger recovery after agent failover.
Diffs (updated)
-----
src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
Diff: https://reviews.apache.org/r/41962/diff/
Testing
-------
make (OSX & Centos7)
Tests are run in the next review.
Thanks,
Joseph Wu
Re: Review Request 41962: Logger Module: Add tests for module
recovery after agent failover.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 1:13 a.m.)
Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Changes
-------
Fix an unsatisfied call to `process::reap`, which interferes with the next test that needs to reap something. `process::reap(0)` will end up doing the reap first. The next reap will instead return `None` instead of a status code.
Bugs: MESOS-4150
https://issues.apache.org/jira/browse/MESOS-4150
Repository: mesos
Description
-------
Adds two heavily-mocked tests for the Mesos containerizer and Docker containerizer. Each checks that `ContainerLogger::recover` is called during `Containerizer::recover`.
Diffs (updated)
-----
src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
Diff: https://reviews.apache.org/r/41962/diff/
Testing
-------
make (OSX & Centos7)
Tests are run in the next review.
Thanks,
Joseph Wu
Re: Review Request 41962: Logger Module: Add tests for module
recovery after agent failover.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:42 p.m.)
Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Changes
-------
Restore another summary/description lost to the tweaked apply-reviews :)
Summary (updated)
-----------------
Logger Module: Add tests for module recovery after agent failover.
Bugs: MESOS-4150
https://issues.apache.org/jira/browse/MESOS-4150
Repository: mesos
Description (updated)
-------
Adds two heavily-mocked tests for the Mesos containerizer and Docker containerizer. Each checks that `ContainerLogger::recover` is called during `Containerizer::recover`.
Diffs
-----
src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
Diff: https://reviews.apache.org/r/41962/diff/
Testing
-------
make (OSX & Centos7)
Tests are run in the next review.
Thanks,
Joseph Wu
Re: Review Request 41962: Add test for ContainerLogger recovery after
agent failover.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 5:02 p.m.)
Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Changes
-------
Rebase and deal with an earlier change to the headers.
Bugs: MESOS-4150
https://issues.apache.org/jira/browse/MESOS-4150
Repository: mesos
Description
-------
Add test for ContainerLogger recovery after agent failover.
Diffs (updated)
-----
src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
Diff: https://reviews.apache.org/r/41962/diff/
Testing
-------
make (OSX & Centos7)
Tests are run in the next review.
Thanks,
Joseph Wu