[GitHub] [spark] viirya commented on a change in pull request #30558: [SPARK-33612][SQL] Add rewriteRules batch to Optimizer

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #30558:
URL: https://github.com/apache/spark/pull/30558#discussion_r533152986



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -185,6 +185,9 @@ abstract class Optimizer(catalogManager: CatalogManager)
       RemoveLiteralFromGroupExpressions,
       RemoveRepetitionFromGroupExpressions) :: Nil ++
     operatorOptimizationBatch) :+
+    // This batch rewrites plans and should be run after the operator
+    // optimization batch and before any batches that depend on stats.
+    Batch("Rewrite Rules", Once, rewriteRules: _*) :+

Review comment:
       Hmm, same question. This naming looks too general.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org