[jira] [Comment Edited] (ACCUMULO-2452) DfsLogger.write(LogFileKey, LogFileValue) flushes with every call

["John Vines (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930483#comment-13930483 ] 

John Vines edited comment on ACCUMULO-2452 at 3/11/14 3:52 PM:
---------------------------------------------------------------

It doesn't actually flush all the way down the stack. The loggers are wrapped in an output stream that catches the flush on that stream, so it doesn't affect normal operations.


was (Author: vines):
It doesn't actually flush. The loggers are wrapped in an output stream that catches the flush on that stream, so it doesn't affect normal operations.

> DfsLogger.write(LogFileKey, LogFileValue) flushes with every call
> -----------------------------------------------------------------
>
>                 Key: ACCUMULO-2452
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2452
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: tserver
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>             Fix For: 1.6.0
>
>
> I was reviewing {{DfsLogger}} today and explaining how it works.  I noticed that every write of every event calls {{flush()}} on output file.  This should be unnecessary since the flush thread should do all the flush/sync operations. It may be necessary for the encryption stuff, but we'll need to figure out some sort of alternative implementation for non-encrypted output.



--
This message was sent by Atlassian JIRA
(v6.2#6252)