[GitHub] [flink] matriv commented on a change in pull request #18439: [hotfix][table-planner][test] Test fromValues() watermark propagation

[GitBox <gi...@apache.org>]

matriv commented on a change in pull request #18439:
URL: https://github.com/apache/flink/pull/18439#discussion_r794425273



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java
##########
@@ -426,6 +424,49 @@ public void testNullEnforcer() throws ExecutionException, InterruptedException {
         }
     }
 
+    @Test
+    public void testFromValuesWatermarkPropagation() throws Exception {
+        final StreamTableEnvironment tableEnv = StreamTableEnvironment.create(env);
+        final SharedReference<List<Long>> watermarks = sharedObjects.add(new ArrayList<>());
+        final TableDescriptor sinkDescriptor =
+                TableFactoryHarness.newBuilder()
+                        .schema(Schema.newBuilder().column("a", "INT").build())

Review comment:
       Sorry Timo, I don't get what you mean, I'm already using `.executeInsert(sinkDescriptor)`.
   Shouldn't the schema be defined both for source and sink?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org