[GitHub] ZhennanQin opened a new pull request #14113: Enhance subgraph API

[GitBox <gi...@apache.org>]

ZhennanQin opened a new pull request #14113: Enhance subgraph API
URL: https://github.com/apache/incubator-mxnet/pull/14113
 
 
   Major change in this API:
   
   * Introduce `SubgraphSelectorV2` that accepts `SimpleNode` instead of `nnvm::Node` to get full context of visited node. `SimpleNode` is double linked version of  `nnvm::Node`, which can list the output consumer of node. This is very useful to help make selection which has output requirement. Wrapper class `SubgraphSelectorV2Bridge` is added to convert `SubgraphSelector` to `SubgraphSelectorV2`, which allows developer to continue using old `SubgraphSelector`. So this feature is fully back-compatible.
   
   * Introduce `kAdjust` mode for `SubgraphProperty` to allow adjusting network parameters instead of create new node. New API `AdjustSubgraphNode()` is added to  `SubgraphProperty` for this, which can adjust selected nodes attributes. This is useful when we don't want to create new subgraph node, but to do some modification on selected nodes. Quantized scale alignment optimization is pending on this feature.
   
   * Add `inference_only` attr support when `SubgraphProperty` is created to indicate that this pass should be used for inference only.
   
   * Allow registering multiple subgraph pass within same backend names.
   
   * Refactor the way to run PartitionGraph in simple bind stage to ensure any graph nodes reordering can be correctly handled.
   
   * Change the behavior of PartitionGraph to create single subgraph node for nodes isolating with each other. https://cwiki.apache.org/confluence/display/MXNET/Enable+Operator+Level+Parallelism+under+Subgraph is depending on this change.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services