You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/12/16 13:30:13 UTC

[GitHub] [phoenix] stoty edited a comment on pull request #1353: PHOENIX-6587 Disallow specifying explicit pre-split on salted tables

stoty edited a comment on pull request #1353:
URL: https://github.com/apache/phoenix/pull/1353#issuecomment-995667065


   Note that new patch removes the SchemaUtil.processSplit() logic, which attempts to expend the split point to cover the whole PK.
   
   My reasons removing it:
   
   * It uses arbitrary lengths when working with PKs with variable length fields, and does not (and can not, because the length is not fixed) cover the actual PK.
   * I could not figure why it was there in the first place.
   * It made adding the validation logic awkward


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org