You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/06/18 11:06:05 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/481
CLOUDSTACK-8556: Unable to delete attached volume in cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack deleteVolume
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #481
----
commit 9f13d8ebc9e4db6ac2ea39122b7406f809ccc591
Author: pritisarap12 <pr...@clogeny.com>
Date: 2015-06-18T09:03:03Z
CLOUDSTACK-8556: Unable to delete attached volume in cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-115109007
Delete volume was failing in cleanup before because volume was not in detached state as snapshot creation failed and detach volume command did not get executed so volume remains in attached state.
Now the detach volume is executed in tearDown class itself so clean up does not fail for volume.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121159832
In that case LGTM
Next time try to be more descriptive, since the Jira issue didn't show it either. I really didn't know what you meant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121829664
LGTM, squashing and merging; please squash your changes in future as you iterate on your PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-113485973
Removed reboot as it is not needed.
Below is the test result after removing reboot function:
Storage and Snapshot Limit ... === TestName: test_01_storage_snapshots_limits | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 300.585s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r32713393
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -341,4 +339,8 @@ def test_05_storage_snapshots_limits(self):
data_volumes_list[0]
)
+ self.vm.reboot(self.apiclient)
--- End diff --
Why reboot and then delete? Also add suitable description and test run log results to the description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r33268358
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -115,32 +115,51 @@ def tearDownClass(cls):
raise Exception("Warning: Exception during cleanup : %s" % e)
def setUp(self):
+ if not self.snapshotSupported:
+ self.skipTest(
+ "Snapshots are not supported on %s" %
+ self.hypervisor)
+
self.apiclient = self.testClient.getApiClient()
self.dbclient = self.testClient.getDbConnection()
self.cleanup = []
--- End diff --
cleanup has to be declared before skipping the test case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to
delete attache...
Posted by Sanjeev N <sa...@apache.org>.
You are right Wido. It is only a test case change to handle volume cleanup.
On Tue, Jul 14, 2015 at 11:43 AM, wido <gi...@git.apache.org> wrote:
> Github user wido commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/481#issuecomment-121140868
>
> The description of the pull request isn't really specific. Looking at
> the files changed it is only a test case which changed, right? No CS code
> itself.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121140868
The description of the pull request isn't really specific. Looking at the files changed it is only a test case which changed, right? No CS code itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by gauravaradhye <gi...@git.apache.org>.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-113487609
Can you please explain why the test case was failing before? Why the cleanup was failing for volume?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r33328911
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -115,32 +115,51 @@ def tearDownClass(cls):
raise Exception("Warning: Exception during cleanup : %s" % e)
def setUp(self):
+ if not self.snapshotSupported:
+ self.skipTest(
+ "Snapshots are not supported on %s" %
+ self.hypervisor)
+
self.apiclient = self.testClient.getApiClient()
self.dbclient = self.testClient.getDbConnection()
self.cleanup = []
--- End diff --
Updated testpath as per the review comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---