You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/08/06 10:22:33 UTC

Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Bugs: CLOUDSTACK-3723


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0.


Diffs
-----

  setup/db/db/schema-410to420.sql f98bb50 
  setup/db/templates.sql ba13841 

Diff: https://reviews.apache.org/r/13316/diff/


Testing
-------

Verifed the fix locally on cloudstack environment:

1. Created CS environment successfully.
2. SystemVMs are coming up fine.
3. UserVMs are getting deployed successfully.


Thanks,

Sanjay Tripathi


Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/#review24713
-----------------------------------------------------------


Review 13316 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #113 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/113/

- Jenkins Cloudstack.org


On Aug. 6, 2013, 9:14 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13316/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 9:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3723
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.
> 
> Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 9cdbd84 
>   setup/db/db/schema-410to420.sql f98bb50 
>   setup/db/templates.sql ba13841 
> 
> Diff: https://reviews.apache.org/r/13316/diff/
> 
> 
> Testing
> -------
> 
> Verifed the fix locally on cloudstack environment:
> 
> 1. Created CS environment successfully.
> 2. SystemVMs are coming up fine.
> 3. UserVMs are getting deployed successfully.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/#review24782
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On Aug. 6, 2013, 9:14 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13316/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 9:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3723
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.
> 
> Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 9cdbd84 
>   setup/db/db/schema-410to420.sql f98bb50 
>   setup/db/templates.sql ba13841 
> 
> Diff: https://reviews.apache.org/r/13316/diff/
> 
> 
> Testing
> -------
> 
> Verifed the fix locally on cloudstack environment:
> 
> 1. Created CS environment successfully.
> 2. SystemVMs are coming up fine.
> 3. UserVMs are getting deployed successfully.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/#review24780
-----------------------------------------------------------


Commit 23aaeafd21aa667a82dca813e7314ab60a6b2ac7 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=23aaeaf ]

CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database

Also added the debian 7 to debian 6 mapping in CitrixHelper file
to support the debian 7 template in XS 6.0, 6.0.2, 6,1 etc.


- ASF Subversion and Git Services


On Aug. 6, 2013, 9:14 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13316/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 9:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3723
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.
> 
> Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 9cdbd84 
>   setup/db/db/schema-410to420.sql f98bb50 
>   setup/db/templates.sql ba13841 
> 
> Diff: https://reviews.apache.org/r/13316/diff/
> 
> 
> Testing
> -------
> 
> Verifed the fix locally on cloudstack environment:
> 
> 1. Created CS environment successfully.
> 2. SystemVMs are coming up fine.
> 3. UserVMs are getting deployed successfully.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/#review24781
-----------------------------------------------------------


Commit 0b00e13e24d9207067e64eaa714f7adee31958da in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0b00e13 ]

CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database

Also added the debian 7 to debian 6 mapping in CitrixHelper file
to support the debian 7 template in XS 6.0, 6.0.2, 6,1 etc.


- ASF Subversion and Git Services


On Aug. 6, 2013, 9:14 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13316/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 9:14 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-3723
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.
> 
> Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 9cdbd84 
>   setup/db/db/schema-410to420.sql f98bb50 
>   setup/db/templates.sql ba13841 
> 
> Diff: https://reviews.apache.org/r/13316/diff/
> 
> 
> Testing
> -------
> 
> Verifed the fix locally on cloudstack environment:
> 
> 1. Created CS environment successfully.
> 2. SystemVMs are coming up fine.
> 3. UserVMs are getting deployed successfully.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 9:14 a.m.)


Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Changes
-------

Added the mapping in CitrixHelper file to support Debain 7 in older XS versions.


Bugs: CLOUDSTACK-3723


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0.


Diffs (updated)
-----

  plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 9cdbd84 
  setup/db/db/schema-410to420.sql f98bb50 
  setup/db/templates.sql ba13841 

Diff: https://reviews.apache.org/r/13316/diff/


Testing
-------

Verifed the fix locally on cloudstack environment:

1. Created CS environment successfully.
2. SystemVMs are coming up fine.
3. UserVMs are getting deployed successfully.


Thanks,

Sanjay Tripathi