You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sanjaydasgupta <gi...@git.apache.org> on 2018/04/30 01:33:34 UTC
[GitHub] zeppelin pull request #2953: [Zeppelin 3388] Refactor documentation for Zepp...
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2953
[Zeppelin 3388] Refactor documentation for ZeppelinContext
### What is this PR for?
This PR is a refactoring of the `ZepplinContext` documentation.
The description of `ZepplinContext` is now almost entirely contained within the _Spark_ interpreter's documentation ([spark.md](https://github.com/apache/zeppelin/blob/master/docs/interpreter/spark.md)). But `ZepplinContext` has many generic features that are available to all interpreters, and it is important for `ZepplinContext` to have a more visible and independent presence in the Zeppelin documentation.
### What type of PR is it?
[Documentation]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3388
### How should this be tested?
Only documentation.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No (This _is_ documentation)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjaydasgupta/zeppelin zeppelin-3388
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2953.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2953
----
----
---
[GitHub] zeppelin issue #2953: [Zeppelin 3388] Refactor documentation for ZeppelinCon...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2953
LGTM, merge if more comments
---
[GitHub] zeppelin issue #2953: [Zeppelin 3388] Refactor documentation for ZeppelinCon...
Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2953
This is how it looks when squeezed into a really narrow space:

And it resizes nicely with changing width too.
Thanks @felixcheung
---
[GitHub] zeppelin pull request #2953: [Zeppelin 3388] Refactor documentation for Zepp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2953
---
[GitHub] zeppelin issue #2953: [Zeppelin 3388] Refactor documentation for ZeppelinCon...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2953
Thanks @sanjaydasgupta LGTM
will merge it to branch-0.8 and master
---
[GitHub] zeppelin issue #2953: [Zeppelin 3388] Refactor documentation for ZeppelinCon...
Posted by sanjaydasgupta <gi...@git.apache.org>.
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2953
Hi @felixcheung, have addressed your comments above.
Documentation written by a worldwide team of contributors can be notoriously ambiguous, and am happy to get a thorough review of this contribution.
Thanks for your time.
---