You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/10/16 10:26:07 UTC
Review Request 63024: Fixed flakiness in
'ResourceProviderRegistrarTest.AgentRegistrar'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63024/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8095
https://issues.apache.org/jira/browse/MESOS-8095
Repository: mesos
Description
-------
This test create an agent registrar which attempted to store its state
in the agent's meta directory before the agent had set up that
directory hierarchy.
This patch adds additional waiting to make sure required directories
have been set up before starting the agent registrar.
Diffs
-----
src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff
Diff: https://reviews.apache.org/r/63024/diff/1/
Testing
-------
* without patch running test in repetition under load fails after a few hundred iterations,
* with this patch running test in repetition under load does not fail in a few thousand iterations.
Thanks,
Benjamin Bannier
Re: Review Request 63024: Fixed flakiness in
'ResourceProviderRegistrarTest.AgentRegistrar'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63024/#review188122
-----------------------------------------------------------
PASS: Mesos patch 63024 was successfully built and tested.
Reviews applied: `['63024']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63024
- Mesos Reviewbot Windows
On Oct. 16, 2017, 10:26 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63024/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8095
> https://issues.apache.org/jira/browse/MESOS-8095
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test create an agent registrar which attempted to store its state
> in the agent's meta directory before the agent had set up that
> directory hierarchy.
>
> This patch adds additional waiting to make sure required directories
> have been set up before starting the agent registrar.
>
>
> Diffs
> -----
>
> src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff
>
>
> Diff: https://reviews.apache.org/r/63024/diff/1/
>
>
> Testing
> -------
>
> * without patch running test in repetition under load fails after a few hundred iterations,
> * with this patch running test in repetition under load does not fail in a few thousand iterations.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63024: Fixed flakiness in
'ResourceProviderRegistrarTest.AgentRegistrar'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63024/#review188123
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63024]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 16, 2017, 10:26 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63024/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8095
> https://issues.apache.org/jira/browse/MESOS-8095
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test create an agent registrar which attempted to store its state
> in the agent's meta directory before the agent had set up that
> directory hierarchy.
>
> This patch adds additional waiting to make sure required directories
> have been set up before starting the agent registrar.
>
>
> Diffs
> -----
>
> src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff
>
>
> Diff: https://reviews.apache.org/r/63024/diff/1/
>
>
> Testing
> -------
>
> * without patch running test in repetition under load fails after a few hundred iterations,
> * with this patch running test in repetition under load does not fail in a few thousand iterations.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 63024: Fixed flakiness in
'ResourceProviderRegistrarTest.AgentRegistrar'.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63024/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 12:23 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8095
https://issues.apache.org/jira/browse/MESOS-8095
Repository: mesos
Description (updated)
-------
This test created an agent registrar which attempted to store its state
in the agent's meta directory before the agent had set up that
directory hierarchy.
This patch adds additional waiting to make sure required directories
have been set up before starting the agent registrar.
Diffs
-----
src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff
Diff: https://reviews.apache.org/r/63024/diff/1/
Testing
-------
* without patch running test in repetition under load fails after a few hundred iterations,
* with this patch running test in repetition under load does not fail in a few thousand iterations.
Thanks,
Benjamin Bannier