[GitHub] kafka pull request #4143: MINOR: PartitionReassignmentHandler should generat...

[ijuma <gi...@git.apache.org>]

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/4143

    MINOR: PartitionReassignmentHandler should generate event only when znode is created and eliminate unnecessary allocations

    As suggested by Jun in https://github.com/apache/kafka/pull/4141, we
    only need to generate the event when the znode is created (
    controller failover restarts the reassignment without generating
    an event).
    
    I also took the chance to eliminate all the unnecessary allocations
    of `TopicPartition` and `TopicAndPartition`. We now use the former
    in the Controller (bringing it inline with the rest of the non legacy
    code).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka partition-reassignment-ignore-handle-deletion-and-data-change

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4143
    
----
commit f2a81b5ef493e428d93be3340148f101089d87e3
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-10-27T09:46:02Z

    Don't create PartitionReassignment event if the znode is deleted or changed

commit 9f448fda833db54e2d558fc69f0e882f9262fab6
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-10-27T10:25:34Z

    Use TopicPartition in Controller and avoid allocations

----


---

[GitHub] kafka pull request #4143: MINOR: PartitionReassignmentHandler should only ge...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4143


---