You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/19 11:10:20 UTC
[GitHub] [rocketmq] shendongsd opened a new pull request #2012: delete useless code for AbstractSendMessageProcessor.java
shendongsd opened a new pull request #2012:
URL: https://github.com/apache/rocketmq/pull/2012
## What is the purpose of the change
delete useless code for AbstractSendMessageProcessor.java
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2012: [Issue 2013]delete useless code for AbstractSendMessageProcessor.java
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2012:
URL: https://github.com/apache/rocketmq/pull/2012#issuecomment-631180619
[](https://coveralls.io/builds/30906066)
Coverage decreased (-0.06%) to 50.9% when pulling **3ab377037ad450fe68f47a1e0171da928836ece9 on shendongsd:feature_broker** into **7f105361022f3a0de8c1d6feda04d5eba3dba6bb on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #2012: [Issue 2013]delete useless code for AbstractSendMessageProcessor.java
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2012:
URL: https://github.com/apache/rocketmq/pull/2012#issuecomment-631180865
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2012?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@8ef01a6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2012 +/- ##
==========================================
Coverage ? 45.11%
Complexity ? 4197
==========================================
Files ? 545
Lines ? 35732
Branches ? 4744
==========================================
Hits ? 16122
Misses ? 17561
Partials ? 2049
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2012?src=pr&el=footer). Last update [8ef01a6...3ab3770](https://codecov.io/gh/apache/rocketmq/pull/2012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling closed pull request #2012: [ISSUE #2013]delete useless code for AbstractSendMessageProcessor.java
Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #2012:
URL: https://github.com/apache/rocketmq/pull/2012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org