[jira] [Commented] (THRIFT-2882) Lua Generator: using string.len funtion to get struct(map,list,set) size

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239120#comment-14239120 ] 

ASF GitHub Bot commented on THRIFT-2882:
----------------------------------------

GitHub user winsweet opened a pull request:

    https://github.com/apache/thrift/pull/311

    THRIFT-2882 Lua Generator: using string.len funtion to get

    struct(map,list,set) size

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/winsweet/thrift THRIFT-2882

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #311
    
----
commit e0886a43bdbce090bd2950df84c270bce4fcdff9
Author: winsweet <wi...@gmail.com>
Date:   2014-12-09T08:14:51Z

    THRIFT-2882 Lua Generator: using string.len funtion to get
    struct(map,list,set) size

----


> Lua Generator: using string.len funtion to get struct(map,list,set) size
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-2882
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2882
>             Project: Thrift
>          Issue Type: Bug
>          Components: Lua - Compiler
>            Reporter: winsweet
>
> #t_lua_generator::generate_serialize_container
> string.len can't get struct's size.
> Tables are the only "container" type in Lua.
> We can get the "length" of an array using the # operator.
> But the # operator doesn't count all the items in the table.
> So when ttype equals to list, # should be OK.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)