[jira] [Comment Edited] (HADOOP-10775) Shell operations to fail with meaningful errors on windows if winutils.exe not found

["Chris Nauroth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900999#comment-14900999 ] 

Chris Nauroth edited comment on HADOOP-10775 at 10/4/15 9:14 PM:
-----------------------------------------------------------------

Hi [~stevel@apache.org].  This looks like a nice improvement.  I can do some test runs on Windows after we work through some feedback.

Is it time to remove {{Shell#isJava7OrAbove}} instead of stubbing it to return {{true}}?  With the promotion of the class to {{Public}} status, I'd be concerned that other projects could choose to call it and expect an accurate answer.

Can we change {{getQualifiedBin}} and {{getQualifiedBinPath}} to {{private}}?

Should the {{WINUTILS}} constant be made {{private}}?  It appears your patch already cleans up nearly all direct references to it.

Since this patch essentially removes the Java 6 symlink workaround special path, shall we change {{SymlinkBaseTest}} and {{TestSymlinkLocalFS}} to remove the {{emulatingSymlinksOnWindows}} checks?



was (Author: cnauroth):
Hi [~stevel@apache.org].  This looks like I nice improvement.  I can do some test runs on Windows after we work through some feedback.

Is it time to remove {{Shell#isJava7OrAbove}} instead of stubbing it to return {{true}}?  With the promotion of the class to {{Public}} status, I'd be concerned that other projects could choose to call it and expect an accurate answer.

Can we change {{getQualifiedBin}} and {{getQualifiedBinPath}} to {{private}}?

Should the {{WINUTILS}} constant be made {{private}}?  It appears your patch already cleans up nearly all direct references to it.

Since this patch essentially removes the Java 6 symlink workaround special path, shall we change {{SymlinkBaseTest}} and {{TestSymlinkLocalFS}} to remove the {{emulatingSymlinksOnWindows}} checks?


> Shell operations to fail with meaningful errors on windows if winutils.exe not found
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10775
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10775
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: trunk-win, 2.7.1
>         Environment: windows
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch, HADOOP-10775-004.patch, HADOOP-10775-005.patch, HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other causes, then an error is logged -but when any of the {{Shell}} operations are used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before any attempt to invoke a winutils-driven process made



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)