You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/09 07:37:54 UTC

[GitHub] [echarts] urgrund commented on issue #15831: v5.0+ Tooltip injected css won't respect

urgrund commented on issue #15831:
URL: https://github.com/apache/echarts/issues/15831#issuecomment-939248557


   Hi Ovilia,  thanks for the response and suggestions!  :)
   
   Though I think I might have used wrong terminology.    I am talking about the inline CSS that eCharts uses that takes priority over custom class.
   
   The **!important** solution I feel is just a workaround - custom classes may be used elsewhere in the application,  so having to decorate properties with !important just to get around v5 introduced behavior is not ideal.
   
   When providing a class with the **className** property in a series/option ,  I would expect that class to take priority.  Upon some more testing, the !important workaround does not appear resolve the will-change issue that breaks backdrop filters _(ie. will-change:unset !important in custom class)_ in eCharts5. 
   
   I would consider this is still a Bug  _(bug tag was removed?)_ or at the least a regression, as user content that worked in eCharts4 no longer works in eCharts5.   
   
   Could eCharts not omit it's own inline css properties conditionally if a custom class is passed in?  Or just allow users to have total control through_ custom classes?
   
   Thanks for taking the time to read and if there are any more tests that I could assist with let me know! :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org