You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/07 10:30:31 UTC
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6228: Support JaCoCo and other quality checks
rohityadavcloud commented on code in PR #6228:
URL: https://github.com/apache/cloudstack/pull/6228#discussion_r844977182
##########
.github/workflows/pull-request-checks.yml:
##########
@@ -15,17 +15,45 @@
# specific language governing permissions and limitations
# under the License.
-name: Lint Code Base
+name: Check Pull Request
on: [pull_request]
jobs:
build:
- name: GitHub Super Linter
+ name: Pull Request Checks
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- - uses: github/super-linter@v4
+ - name: SuperLinter Lint Checks
+ uses: github/super-linter@v4
env:
VALIDATE_PYTHON_FLAKE8: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+ - name: Set up JDK11
+ uses: actions/setup-java@v2
+ with:
+ distribution: 'temurin'
+ java-version: '11'
+ cache: 'maven'
+
+ - name: Install nonoss jar dependencies
+ run: |
+ git clone https://github.com/shapeblue/cloudstack-nonoss.git deps
+ cd deps && bash -x install-non-oss.sh && cd ..
+
+ - name: Run Tests with JaCoCo
+ run: mvn -P developer,systemvm,quality -Dsimulator -Dnoredist clean test
+
+ #- name: Generate JaCoCo Report
+ # id: jacoco
+ # uses: Madrapps/jacoco-report@v1.2
+ # with:
+ # paths: ${{ github.workspace }}/**/jacoco.xml
+ # token: ${{ secrets.GITHUB_TOKEN }}
+ # min-coverage-overall: 0
+ # min-coverage-changed-files: 80
+ # title: PR Code Coverage
+ # debug-mode: true
Review Comment:
I'll enable this once the current workflow build works, by default it doesn't work as ASF infra has disallowed arbitrary actions to run. We may need to check with ASF infra is this is even allowed by them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org