[GitHub] [systemds] Baunsgaard commented on pull request #1239: [PythonAPI] frame support

[GitBox <gi...@apache.org>]

Baunsgaard commented on pull request #1239:
URL: https://github.com/apache/systemds/pull/1239#issuecomment-826325153


   > I saw that the build failed because of some missing license headers, sorry for that but I think I found the missing ones.
   > 
   > Reverting the formatting changes using black didn't work, only would have changed some lines additionally.
   > Thus I reverted the 3 files in question back to the master branch, then checked out my other work in progress branch for those files and went through the diffs and changes one by one.
   > 
   > I would also have a question about, how your test-suite / CI-yaml configs are created? Because I only saw that the tests are failing because there is no pandas package installed, when looking at the python.yaml I only see:
   > 
   > ` - name: Install pip Dependencies`
   > `run: pip install numpy py4j wheel scipy sklearn requests`
   
   You can add pandas to that line, it will install it for the tests. 
   also add it as a dependency for the python package in general:
   https://github.com/apache/systemds/blob/master/src/main/python/setup.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org