You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/06/24 20:56:47 UTC
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13713
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
IMPALA-8589: Re-enable flaky test_query_event_hooks.py
This patch fixes the flaky test_query_event_hooks.py. The patch also
cuts down the waiting time for impalad timeout to 5 seconds from the
default 60 seconds especially for those tests that will fail Impala
startup.
Testing:
- Ran test_query_event_hooks.py in a loop.
Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
---
M fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_query_event_hooks.py
3 files changed, 67 insertions(+), 142 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/13713/6
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4529/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Mon, 24 Jun 2019 20:57:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4535/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 15:51:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4529/
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 03:20:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
IMPALA-8589: Re-enable flaky test_query_event_hooks.py
This patch fixes the flaky test_query_event_hooks.py. The patch also
cuts down the waiting time for impalad timeout to 5 seconds from the
default 60 seconds especially for those tests that will fail Impala
startup.
Testing:
- Ran test_query_event_hooks.py in a loop.
Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Reviewed-on: http://gerrit.cloudera.org:8080/13713
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java
M fe/src/test/java/org/apache/impala/testutil/AlwaysErrorQueryEventHook.java
M fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
M fe/src/test/java/org/apache/impala/testutil/PostQueryErrorEventHook.java
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_query_event_hooks.py
6 files changed, 126 insertions(+), 196 deletions(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 9
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3741/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 19:56:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
IMPALA-8589: Re-enable flaky test_query_event_hooks.py
This patch fixes the flaky test_query_event_hooks.py. The patch also
cuts down the waiting time for impalad timeout to 5 seconds from the
default 60 seconds especially for those tests that will fail Impala
startup.
Testing:
- Ran test_query_event_hooks.py in a loop.
Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
---
M fe/src/main/java/org/apache/impala/hooks/QueryEventHookManager.java
M fe/src/test/java/org/apache/impala/testutil/AlwaysErrorQueryEventHook.java
M fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
M fe/src/test/java/org/apache/impala/testutil/PostQueryErrorEventHook.java
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_query_event_hooks.py
6 files changed, 126 insertions(+), 196 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/13713/8
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 21:29:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3724/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Mon, 24 Jun 2019 21:36:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 7:
Rebased and re-running the dry-run.
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 15:51:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "radford nguyen (Code Review)" <ge...@cloudera.org>.
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13713/9/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/13713/9/tests/custom_cluster/test_query_event_hooks.py@49
PS9, Line 49: expected_count=-1)
This test no longer checks for the execution of `onQueryComplete`... it only checks that `onImpalaStartup` is called, which is not a query event hook at all, really.
I think we still need coverage for `onQueryComplete` because it executes on the thread pool executor, which is different than `onImpalaStartup`
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 9
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Mon, 08 Jul 2019 20:32:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 00:13:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
Thanks for fixing this, seems much simpler to follow.
http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
File fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java:
http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java@24
PS7, Line 24: public class DummyQueryEventHook implements QueryEventHook {
Add a class comment on how this is supposed to work?
http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py@112
PS7, Line 112: LOG.info(method.func_dict)
remove?
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:40:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4541/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 18:24:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
IMPALA-8589: Re-enable flaky test_query_event_hooks.py
This patch fixes the flaky test_query_event_hooks.py. The patch also
cuts down the waiting time for impalad timeout to 5 seconds from the
default 60 seconds especially for those tests that will fail Impala
startup.
Testing:
- Ran test_query_event_hooks.py in a loop.
Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
---
M fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_query_event_hooks.py
3 files changed, 67 insertions(+), 142 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/13713/7
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
Carry Bharath's +2.
http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java
File fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java:
http://gerrit.cloudera.org:8080/#/c/13713/7/fe/src/test/java/org/apache/impala/testutil/DummyQueryEventHook.java@24
PS7, Line 24: /**
> Add a class comment on how this is supposed to work?
Done
http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:
http://gerrit.cloudera.org:8080/#/c/13713/7/tests/custom_cluster/test_query_event_hooks.py@112
PS7, Line 112:
> remove?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 18:24:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )
Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3738/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:30:38 +0000
Gerrit-HasComments: No