You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MechCoder <gi...@git.apache.org> on 2015/03/27 20:17:57 UTC
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
GitHub user MechCoder opened a pull request:
https://github.com/apache/spark/pull/5232
[SPARK-6576] [MLlib] [PySpark] DenseMatrix in PySpark should support indexing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MechCoder/spark SPARK-6576
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5232
----
commit b2e580ddcbf103a2efcda43f5006a0f6028ff525
Author: MechCoder <ma...@gmail.com>
Date: 2015-03-27T19:12:35Z
[SPARK-6576] DenseMatrix in PySpark should support indexing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88655405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29563/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88630766
@mengxr fixed !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88380645
[Test build #29529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29529/consoleFull) for PR 5232 at commit [`5c0b159`](https://github.com/apache/spark/commit/5c0b159914d96a1712c668c62cd249c1afdce157).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87178758
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29338/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88487550
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29542/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87180177
@mengxr I think this one is ready to go, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27534795
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,17 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i = indices[0]
+ j = indices[1]
+ if i > self.numRows:
--- End diff --
`or i < 0` and please also update the error message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27534793
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,17 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i = indices[0]
--- End diff --
This is cleaner:
~~~python
i, j = indices
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87160425
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29337/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88457523
[Test build #29542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29542/consoleFull) for PR 5232 at commit [`a062025`](https://github.com/apache/spark/commit/a0620254debb8ab0c305a7c9962c1e6030c66289).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27534799
--- Diff: python/pyspark/mllib/tests.py ---
@@ -134,6 +134,14 @@ def test_sparse_vector_indexing(self):
for ind in [4, -5, 7.8]:
self.assertRaises(ValueError, sv.__getitem__, ind)
+ def test_matrix_indexing(self):
+ mat = DenseMatrix(3, 2, [0, 1, 4, 6, 8, 10])
+ numcols = mat.numCols
+ for ind, val in enumerate(mat.values):
--- End diff --
I think it should be okay to write down the checks explicitly. Or you can do this:
~~~python
expected = [[0, 6], [1, 8], [4, 10]]
for i in range(3):
for j in range(2):
self.assertEquals(mat[i, j], xpected[i][j])
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87065695
[Test build #29320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29320/consoleFull) for PR 5232 at commit [`a059537`](https://github.com/apache/spark/commit/a05953753ed370d8ce7a6cf006ced99376cc6fc3).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87067088
@davies The Python lint checks pass in my laptop, but due to some unrelated issue, it fails here, Cab you have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87098858
[Test build #630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/630/consoleFull) for PR 5232 at commit [`a059537`](https://github.com/apache/spark/commit/a05953753ed370d8ce7a6cf006ced99376cc6fc3).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87064934
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29319/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87065893
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29320/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88655398
[Test build #29563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29563/consoleFull) for PR 5232 at commit [`a735078`](https://github.com/apache/spark/commit/a7350788e3ae943ed898cb36ed500880459b7596).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87063940
Jenkins, OK to test.
LGTM, just one minor comments. You could run dev/lint-python to do python style check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87161776
[Test build #29338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29338/consoleFull) for PR 5232 at commit [`c6bae51`](https://github.com/apache/spark/commit/c6bae51b6e64558997fadc3c144fbd2b46408386).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87062274
cc: @davies @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87155694
[Test build #29337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29337/consoleFull) for PR 5232 at commit [`dd84d21`](https://github.com/apache/spark/commit/dd84d2185a385399dc47043c703b117ddee1d78d).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87064432
[Test build #29319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29319/consoleFull) for PR 5232 at commit [`b2e580d`](https://github.com/apache/spark/commit/b2e580ddcbf103a2efcda43f5006a0f6028ff525).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87064208
[Test build #629 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/629/consoleFull) for PR 5232 at commit [`b2e580d`](https://github.com/apache/spark/commit/b2e580ddcbf103a2efcda43f5006a0f6028ff525).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87064859
@davies Thanks. I fixed and amended the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27323661
--- Diff: python/pyspark/mllib/tests.py ---
@@ -134,6 +134,13 @@ def test_sparse_vector_indexing(self):
for ind in [4, -5, 7.8]:
self.assertRaises(ValueError, sv.__getitem__, ind)
+ def test_matrix_indexing(self):
+ mat = DenseMatrix(3, 2, [0, 1, 4, 6, 8, 10])
+ for ind, val in enumerate(mat.values):
+ rowind = ind // numcols
+ colind = ind - rowind * numcols
+ self.assertEquals(mat[rowind , colind], val)
--- End diff --
nit: no space need before `,`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27534796
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,17 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i = indices[0]
+ j = indices[1]
+ if i > self.numRows:
+ raise ValueError("Row index %d should not be greater than numRows %d." %
+ (i, self.numRows))
+ if j > self.numCols:
--- End diff --
`or j < 0`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87064812
[Test build #629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/629/consoleFull) for PR 5232 at commit [`b2e580d`](https://github.com/apache/spark/commit/b2e580ddcbf103a2efcda43f5006a0f6028ff525).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class TaskCommitDenied(jobID: Int, partitionID: Int, attemptID: Int) extends TaskFailedReason `
* `class JavaDoubleRDD(val srdd: RDD[scala.Double])`
* ` case class UnregisterApplication(appId: String)`
* `class ExecutorSource(threadPool: ThreadPoolExecutor, executorId: String) extends Source `
* `case class ExecutorCacheTaskLocation(override val host: String, executorId: String)`
* `class RegexTokenizer extends UnaryTransformer[String, Seq[String], RegexTokenizer] `
* ` case class Data(weight: Double, mu: Vector, sigma: Matrix)`
* `class MLPairRDDFunctions[K: ClassTag, V: ClassTag](self: RDD[(K, V)]) extends Serializable `
* `class NaiveBayesModel(Saveable, Loader):`
* `class KMeansModel(Saveable, Loader):`
* `class SqlParser extends AbstractSparkSQLParser with DataTypeParser `
* ` implicit class DslSymbol(sym: Symbol) extends ImplicitAttribute `
* `case class CombineSum(child: Expression) extends AggregateExpression `
* `case class CombineSumFunction(expr: Expression, base: AggregateExpression)`
* `case class Alias(child: Expression, name: String)(`
* `protected[sql] class DataTypeException(message: String) extends Exception(message)`
* `class Column(protected[sql] val expr: Expression) extends Logging `
* ` class CheckpointWriteHandler(`
* ` logError("User class threw exception: " + cause, cause)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87178736
[Test build #29338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29338/consoleFull) for PR 5232 at commit [`c6bae51`](https://github.com/apache/spark/commit/c6bae51b6e64558997fadc3c144fbd2b46408386).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class Normalizer extends UnaryTransformer[Vector, Vector, Normalizer] `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88377697
[Test build #29523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29523/consoleFull) for PR 5232 at commit [`06b5ed5`](https://github.com/apache/spark/commit/06b5ed5529ff9b206893275bf88d480d384aae60).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88403013
[Test build #29529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29529/consoleFull) for PR 5232 at commit [`5c0b159`](https://github.com/apache/spark/commit/5c0b159914d96a1712c668c62cd249c1afdce157).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88487533
[Test build #29542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29542/consoleFull) for PR 5232 at commit [`a062025`](https://github.com/apache/spark/commit/a0620254debb8ab0c305a7c9962c1e6030c66289).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88215615
@jkbradley Do you mind having a quick look at this? It is a minor PR. Thanks! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88671280
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88369109
@mengxr fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27546365
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,17 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i = indices[0]
+ j = indices[1]
+ if i > self.numRows:
+ raise ValueError("Row index %d should not be greater than numRows %d." %
+ (i, self.numRows))
+ if j > self.numCols:
+ raise ValueError("Column index %d should not be greater than numCols %d." %
+ (i, self.numCols))
+ return self.values[i * self.numCols + j]
--- End diff --
Ouch. I completely forgot that :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27534797
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,17 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i = indices[0]
+ j = indices[1]
+ if i > self.numRows:
+ raise ValueError("Row index %d should not be greater than numRows %d." %
+ (i, self.numRows))
+ if j > self.numCols:
+ raise ValueError("Column index %d should not be greater than numCols %d." %
+ (i, self.numCols))
+ return self.values[i * self.numCols + j]
--- End diff --
This is wrong. We use column-major. So it should be `i + j * self.numRows`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87160408
[Test build #29337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29337/consoleFull) for PR 5232 at commit [`dd84d21`](https://github.com/apache/spark/commit/dd84d2185a385399dc47043c703b117ddee1d78d).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88377719
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29523/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27609996
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,18 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i, j = indices
+ if i > self.numRows or i < 0:
--- End diff --
Extremely sorry for these careless mistakes. I was in a real hurry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by MechCoder <gi...@git.apache.org>.
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87179167
Finally passed all test. Can this be merged now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87064920
[Test build #29319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29319/consoleFull) for PR 5232 at commit [`b2e580d`](https://github.com/apache/spark/commit/b2e580ddcbf103a2efcda43f5006a0f6028ff525).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88366992
[Test build #29523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29523/consoleFull) for PR 5232 at commit [`06b5ed5`](https://github.com/apache/spark/commit/06b5ed5529ff9b206893275bf88d480d384aae60).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88403050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29529/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87065888
[Test build #29320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29320/consoleFull) for PR 5232 at commit [`a059537`](https://github.com/apache/spark/commit/a05953753ed370d8ce7a6cf006ced99376cc6fc3).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5232#discussion_r27609790
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -634,6 +634,18 @@ def toArray(self):
"""
return self.values.reshape((self.numRows, self.numCols), order='F')
+ def __getitem__(self, indices):
+ i, j = indices
+ if i > self.numRows or i < 0:
--- End diff --
Sorry, I didn't notice this in the first pass. The bound should be `[0, numRows)`:
~~~
if i < 0 or i >= self.numRows:
raise ValueError("Row index %d is out of range range [0, %d)" % (i, self.numRows))
~~~
Same for `j` below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-87095964
[Test build #630 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/630/consoleFull) for PR 5232 at commit [`a059537`](https://github.com/apache/spark/commit/a05953753ed370d8ce7a6cf006ced99376cc6fc3).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6576] [MLlib] [PySpark] DenseMatrix in ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5232#issuecomment-88631133
[Test build #29563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29563/consoleFull) for PR 5232 at commit [`a735078`](https://github.com/apache/spark/commit/a7350788e3ae943ed898cb36ed500880459b7596).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org