[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4304: Fix DESCRIBE statement qualified table issue

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4304:
URL: https://github.com/apache/arrow-datafusion/pull/4304#discussion_r1028557384


##########
datafusion/sql/src/parser.rs:
##########
@@ -84,7 +87,7 @@ impl fmt::Display for CreateExternalTable {
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct DescribeTable {
     /// Table name
-    pub table_name: String,
+    pub table_name: ObjectName,

Review Comment:
   👍 



##########
datafusion/core/Cargo.toml:
##########
@@ -107,6 +107,7 @@ doc-comment = "0.3"
 env_logger = "0.9"
 parquet-test-utils = { path = "../../parquet-test-utils" }
 rstest = "0.15.0"
+test-case = "*"

Review Comment:
   I would prefer not to add a new dependency -- especially since the tests are simple and we already have `rstest` https://docs.rs/rstest/latest/rstest/ which also has fixtures
   
   I would be happy to hear other opinions as well from other maintainers
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org