You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devicemap.apache.org by "Radu Cotescu (JIRA)" <ji...@apache.org> on 2013/11/18 15:47:22 UTC
[jira] [Resolved] (DMAP-33) BrowserMap is forwarding the client to
a wrong language variant
[ https://issues.apache.org/jira/browse/DMAP-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Radu Cotescu resolved DMAP-33.
------------------------------
Resolution: Fixed
Fixed in revision [1543040|http://svn.apache.org/viewvc?view=revision&revision=1543040]:
* extended the filter function used for getting the new url to which a client should be forwarded such that the current variant’s
hreflang is taken into consideration
* cleaned some JSDoc typos and misuse of tags
* bumping version to 1.4.0
> BrowserMap is forwarding the client to a wrong language variant
> ---------------------------------------------------------------
>
> Key: DMAP-33
> URL: https://issues.apache.org/jira/browse/DMAP-33
> Project: DeviceMap
> Issue Type: Bug
> Reporter: Radu Cotescu
> Assignee: Radu Cotescu
> Labels: browsermap
>
> If BrowserMap has to forward the client to a different site variant due to better matching of the detected device groups, then the forward will be made to the first variant matching the device groups, without taking into consideration the variant's language.
> E.g.:
> Assume we have the following variants:
> <link rel="alternate" data-bmap-devgroups="browser" hreflang="en" href="http://www.example.com/index.html">
> <link rel="alternate" data-bmap-devgroups="browser" hreflang="de" href="http://www.example.com/index.html">
> <link rel="alternate" data-bmap-devgroups="smartphone" hreflang="en" href="http://www.example.com/index.smartphone.html">
> <link rel="alternate" data-bmap-devgroups="smartphone" hreflang="de" href="http://www.example.com/index.smartphone.html">
> If the current variant is the desktop site in German, assuming BrowserMap would have to forward the client to the mobile version it would pick the English site, as that's the first one that matches the "smartphone" device group.
--
This message was sent by Atlassian JIRA
(v6.1#6144)