You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/11/06 19:31:18 UTC
Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1605
https://issues.apache.org/jira/browse/OOZIE-1605
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1605
Diffs
-----
trunk/webapp/src/main/webapp/oozie-console.js 1538031
Diff: https://reviews.apache.org/r/15276/diff/
Testing
-------
locally tested
Thanks,
Ryota Egashira
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/#review29083
-----------------------------------------------------------
Ship it!
Ship It!
- Purshotam Shah
On Nov. 18, 2013, 10:28 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15276/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 10:28 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1605
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Diffs
> -----
>
> trunk/webapp/src/main/webapp/oozie-console.js 1538031
>
> Diff: https://reviews.apache.org/r/15276/diff/
>
>
> Testing
> -------
>
> locally tested
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/#review29382
-----------------------------------------------------------
Ship it!
Ship It!
- Mona Chitnis
On Nov. 22, 2013, 11:27 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15276/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 11:27 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1605
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Diffs
> -----
>
> trunk/webapp/src/main/webapp/oozie-console.js 1538031
>
> Diff: https://reviews.apache.org/r/15276/diff/
>
>
> Testing
> -------
>
> locally tested
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/
-----------------------------------------------------------
(Updated Nov. 22, 2013, 11:27 p.m.)
Review request for oozie.
Changes
-------
reflected Mona's comment. now status is case-ignored.
when specifying custom filter, say status=succeeded, it automatically translate to status=SUCCEEDED, and put into cookie. (customer filter of WF/COORD/BUNDLE and Global Filter newly added)
Bugs: OOZIE-1605
https://issues.apache.org/jira/browse/OOZIE-1605
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1605
Diffs (updated)
-----
trunk/webapp/src/main/webapp/oozie-console.js 1538031
Diff: https://reviews.apache.org/r/15276/diff/
Testing
-------
locally tested
Thanks,
Ryota Egashira
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/#review29130
-----------------------------------------------------------
Not sure if this has been addressed already in the patch, but can you account for ignoreCase in the status? E.g. currently, if I give in filter "status=killed", it does not work because 'killed' is not in uppercase
- Mona Chitnis
On Nov. 18, 2013, 10:28 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15276/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 10:28 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1605
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Diffs
> -----
>
> trunk/webapp/src/main/webapp/oozie-console.js 1538031
>
> Diff: https://reviews.apache.org/r/15276/diff/
>
>
> Testing
> -------
>
> locally tested
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/
-----------------------------------------------------------
(Updated Nov. 18, 2013, 10:28 p.m.)
Review request for oozie.
Changes
-------
fixed comments, also setting Tab field names.
Bugs: OOZIE-1605
https://issues.apache.org/jira/browse/OOZIE-1605
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1605
Diffs (updated)
-----
trunk/webapp/src/main/webapp/oozie-console.js 1538031
Diff: https://reviews.apache.org/r/15276/diff/
Testing
-------
locally tested
Thanks,
Ryota Egashira
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Nov. 18, 2013, 8:23 p.m., Purshotam Shah wrote:
> >
thanks for review
> On Nov. 18, 2013, 8:23 p.m., Purshotam Shah wrote:
> > trunk/webapp/src/main/webapp/oozie-console.js, line 100
> > <https://reviews.apache.org/r/15276/diff/1/?file=379576#file379576line100>
> >
> > If it check null, then it's fine.
yes, it checks null
> On Nov. 18, 2013, 8:23 p.m., Purshotam Shah wrote:
> > trunk/webapp/src/main/webapp/oozie-console.js, line 1764
> > <https://reviews.apache.org/r/15276/diff/1/?file=379576#file379576line1764>
> >
> > We should parametrize(;status=SUCCEEDED;status=KILLED;status=FAILED;status=DONEWITHERROR'). But considering current state, it' ok. we should plan to refactor.
parametrized long string.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/#review29068
-----------------------------------------------------------
On Nov. 6, 2013, 6:31 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15276/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 6:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1605
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Diffs
> -----
>
> trunk/webapp/src/main/webapp/oozie-console.js 1538031
>
> Diff: https://reviews.apache.org/r/15276/diff/
>
>
> Testing
> -------
>
> locally tested
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15276: [OOZIE-1605] Add common custom filter applied to
Wf/Coord/Bundle jobs on oozie UI
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15276/#review29068
-----------------------------------------------------------
trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/15276/#comment56147>
If it check null, then it's fine.
trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/15276/#comment56153>
We should parametrize(;status=SUCCEEDED;status=KILLED;status=FAILED;status=DONEWITHERROR'). But considering current state, it' ok. we should plan to refactor.
- Purshotam Shah
On Nov. 6, 2013, 6:31 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15276/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 6:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1605
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1605
>
>
> Diffs
> -----
>
> trunk/webapp/src/main/webapp/oozie-console.js 1538031
>
> Diff: https://reviews.apache.org/r/15276/diff/
>
>
> Testing
> -------
>
> locally tested
>
>
> Thanks,
>
> Ryota Egashira
>
>