You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Magnus Naeslund (JIRA)" <ji...@apache.org> on 2005/07/19 13:21:47 UTC
[jira] Created: (DIRMINA-73) The new close(boolean wait) logic seems flawed, never waiting for flush
The new close(boolean wait) logic seems flawed, never waiting for flush
-----------------------------------------------------------------------
Key: DIRMINA-73
URL: http://issues.apache.org/jira/browse/DIRMINA-73
Project: Directory MINA
Type: Bug
Versions: 0.7.3
Environment: N/A
Reporter: Magnus Naeslund
Assigned to: Trustin Lee
Priority: Critical
Attachments: mina-SocketSession-close-fix1.diff
It seems the while (disposed) test should be inverted.
Patch:
--- org/apache/mina/io/socket/SocketSession.java (revision 219643)
+++ org/apache/mina/io/socket/SocketSession.java (working copy)
@@ -130,7 +130,7 @@
SocketIoProcessor.getInstance().removeSession( this );
if( wait )
{
- while( disposed )
+ while( !disposed )
{
try
{
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-73) The new close(boolean wait) logic seems flawed, never waiting for flush
Posted by "Magnus Naeslund (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-73?page=all ]
Magnus Naeslund updated DIRMINA-73:
-----------------------------------
Attachment: mina-SocketSession-close-fix1.diff
I found out i can attach a file instead :)
> The new close(boolean wait) logic seems flawed, never waiting for flush
> -----------------------------------------------------------------------
>
> Key: DIRMINA-73
> URL: http://issues.apache.org/jira/browse/DIRMINA-73
> Project: Directory MINA
> Type: Bug
> Versions: 0.7.3
> Environment: N/A
> Reporter: Magnus Naeslund
> Assignee: Trustin Lee
> Priority: Critical
> Attachments: mina-SocketSession-close-fix1.diff
>
> It seems the while (disposed) test should be inverted.
> Patch:
> --- org/apache/mina/io/socket/SocketSession.java (revision 219643)
> +++ org/apache/mina/io/socket/SocketSession.java (working copy)
> @@ -130,7 +130,7 @@
> SocketIoProcessor.getInstance().removeSession( this );
> if( wait )
> {
> - while( disposed )
> + while( !disposed )
> {
> try
> {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DIRMINA-73) The new close(boolean wait) logic seems flawed, never waiting for flush
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-73?page=all ]
Trustin Lee resolved DIRMINA-73:
--------------------------------
Fix Version: 0.7.4
Resolution: Fixed
> The new close(boolean wait) logic seems flawed, never waiting for flush
> -----------------------------------------------------------------------
>
> Key: DIRMINA-73
> URL: http://issues.apache.org/jira/browse/DIRMINA-73
> Project: Directory MINA
> Type: Bug
> Versions: 0.7.3
> Environment: N/A
> Reporter: Magnus Naeslund
> Assignee: Trustin Lee
> Priority: Critical
> Fix For: 0.7.4
> Attachments: mina-SocketSession-close-fix1.diff
>
> It seems the while (disposed) test should be inverted.
> Patch:
> --- org/apache/mina/io/socket/SocketSession.java (revision 219643)
> +++ org/apache/mina/io/socket/SocketSession.java (working copy)
> @@ -130,7 +130,7 @@
> SocketIoProcessor.getInstance().removeSession( this );
> if( wait )
> {
> - while( disposed )
> + while( !disposed )
> {
> try
> {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-73) The new close(boolean wait) logic seems flawed, never waiting for flush
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-73?page=comments#action_12316194 ]
Trustin Lee commented on DIRMINA-73:
------------------------------------
Thank you, Magnus! And I'm sorry for this stupid bug. :)
I'll comment here again after I check in your fix and deploy the 0.7.4-SNAPSHOT jar.
> The new close(boolean wait) logic seems flawed, never waiting for flush
> -----------------------------------------------------------------------
>
> Key: DIRMINA-73
> URL: http://issues.apache.org/jira/browse/DIRMINA-73
> Project: Directory MINA
> Type: Bug
> Versions: 0.7.3
> Environment: N/A
> Reporter: Magnus Naeslund
> Assignee: Trustin Lee
> Priority: Critical
> Attachments: mina-SocketSession-close-fix1.diff
>
> It seems the while (disposed) test should be inverted.
> Patch:
> --- org/apache/mina/io/socket/SocketSession.java (revision 219643)
> +++ org/apache/mina/io/socket/SocketSession.java (working copy)
> @@ -130,7 +130,7 @@
> SocketIoProcessor.getInstance().removeSession( this );
> if( wait )
> {
> - while( disposed )
> + while( !disposed )
> {
> try
> {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-73) The new close(boolean wait) logic seems flawed, never waiting for flush
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-73?page=comments#action_12316330 ]
Trustin Lee commented on DIRMINA-73:
------------------------------------
I checked in the fix. The same bug existed in DatagramSession, so I also patched it. Please test with the recent snapshot, and close this issue.
> The new close(boolean wait) logic seems flawed, never waiting for flush
> -----------------------------------------------------------------------
>
> Key: DIRMINA-73
> URL: http://issues.apache.org/jira/browse/DIRMINA-73
> Project: Directory MINA
> Type: Bug
> Versions: 0.7.3
> Environment: N/A
> Reporter: Magnus Naeslund
> Assignee: Trustin Lee
> Priority: Critical
> Fix For: 0.7.4
> Attachments: mina-SocketSession-close-fix1.diff
>
> It seems the while (disposed) test should be inverted.
> Patch:
> --- org/apache/mina/io/socket/SocketSession.java (revision 219643)
> +++ org/apache/mina/io/socket/SocketSession.java (working copy)
> @@ -130,7 +130,7 @@
> SocketIoProcessor.getInstance().removeSession( this );
> if( wait )
> {
> - while( disposed )
> + while( !disposed )
> {
> try
> {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira