You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "umustafi (via GitHub)" <gi...@apache.org> on 2023/08/11 16:20:13 UTC

[GitHub] [gobblin] umustafi opened a new pull request, #3736: [GOBBLIN-1872] Enable scheduler for non-leader in multi-active scheduler configuration

umustafi opened a new pull request, #3736:
URL: https://github.com/apache/gobblin/pull/3736

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1872
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   Set scheduler to active for all hosts when multi-active scheduler is enabled to allow hosts to use multi-active lease arbiter to handle flow triggers and ensure no missed flows and zero downtime.  
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] codecov-commenter commented on pull request #3736: [GOBBLIN-1872] Enable scheduler for non-leader in multi-active scheduler configuration

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3736:
URL: https://github.com/apache/gobblin/pull/3736#issuecomment-1675084344

   ## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3736?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3736](https://app.codecov.io/gh/apache/gobblin/pull/3736?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5a9b3d0) into [master](https://app.codecov.io/gh/apache/gobblin/commit/af48b310c59593c48bc0491a0b6960d2d8a83e16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (af48b31) will **increase** coverage by `6.83%`.
   > Report is 2 commits behind head on master.
   > The diff coverage is `33.33%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3736      +/-   ##
   ============================================
   + Coverage     47.08%   53.92%   +6.83%     
   + Complexity    10862     1389    -9473     
   ============================================
     Files          2146      281    -1865     
     Lines         84781    10205   -74576     
     Branches       9408     1098    -8310     
   ============================================
   - Hits          39922     5503   -34419     
   + Misses        41238     4181   -37057     
   + Partials       3621      521    -3100     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/gobblin/pull/3736?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...in/service/modules/core/GobblinServiceManager.java](https://app.codecov.io/gh/apache/gobblin/pull/3736?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh) | `47.54% <33.33%> (-0.55%)` | :arrow_down: |
   
   ... and [1868 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3736/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] Will-Lo merged pull request #3736: [GOBBLIN-1872] Enable scheduler for non-leader in multi-active scheduler configuration

Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3736:
URL: https://github.com/apache/gobblin/pull/3736


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org