You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/18 18:53:39 UTC
[GitHub] codecov-io edited a comment on issue #5418: Retire dashboard v1 (js
and python)
codecov-io edited a comment on issue #5418: Retire dashboard v1 (js and python)
URL: https://github.com/apache/incubator-superset/pull/5418#issuecomment-406029832
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=h1) Report
> Merging [#5418](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b0b04b319b79e299fc150837870755c2e0a51a1b?src=pr&el=desc) will **increase** coverage by `4.2%`.
> The diff coverage is `55.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5418 +/- ##
=========================================
+ Coverage 59.1% 63.31% +4.2%
=========================================
Files 372 349 -23
Lines 23747 22092 -1655
Branches 2758 2454 -304
=========================================
- Hits 14036 13987 -49
+ Misses 9696 8091 -1605
+ Partials 15 14 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/logger.js](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9sb2dnZXIuanM=) | `95.31% <ø> (-0.34%)` | :arrow_down: |
| [...ssets/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRIZWFkZXIuanN4) | `100% <ø> (ø)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `71.11% <ø> (-1.23%)` | :arrow_down: |
| [...et/assets/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkU3RhdGUuanM=) | `94.59% <ø> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.96% <0%> (+1.85%)` | :arrow_up: |
| [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `81.81% <100%> (+1.81%)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmQuanN4) | `80.85% <100%> (+0.64%)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `59.3% <100%> (+0.88%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.81% <85.71%> (+0.98%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/5418/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=footer). Last update [b0b04b3...5c80682](https://codecov.io/gh/apache/incubator-superset/pull/5418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org