You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jcobb-healx (via GitHub)" <gi...@apache.org> on 2023/02/27 12:56:49 UTC
[GitHub] [airflow] jcobb-healx opened a new pull request, #29782: Param argument accepts generic dict subtypes
jcobb-healx opened a new pull request, #29782:
URL: https://github.com/apache/airflow/pull/29782
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #29358
Allow subtypes of `dict` to be passed as the DAG and task `params` argument. This ensures that a `ParamsDict` object is a valid type for the argument value.
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1454822871
rebased to rebuild with latest main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1454822549
> I wasn't sure about a test case given this is a typing change, so `mypy` should catch any errors and there are no functional changes. But I can add a test to ensure that a `ParamsDict` object is a valid input to a DAG, which should catch typing regressions
Yeah. I kinda agree that no tests are needed in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1458895414
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1446278237
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jcobb-healx commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "jcobb-healx (via GitHub)" <gi...@apache.org>.
jcobb-healx commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1447827508
I wasn't sure about a test case given this is a typing change, so `mypy` should catch any errors and there are no functional changes. But I can add a test to ensure that a `ParamsDict` object is a valid input to a DAG, which should catch typing regressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1454859838
@msumit - wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on pull request #29782: Param argument accepts generic dict subtypes
Posted by "msumit (via GitHub)" <gi...@apache.org>.
msumit commented on PR #29782:
URL: https://github.com/apache/airflow/pull/29782#issuecomment-1447519218
overall lgtm, though you've to add supported test cases for this. Also, could you ensure you've tested all paths touched by this change, like DAG trigger with config via UI/API/CLI, dag test cmd, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29782: Param argument accepts generic dict subtypes
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29782:
URL: https://github.com/apache/airflow/pull/29782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org