You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jtstorck <gi...@git.apache.org> on 2018/04/30 21:39:46 UTC
[GitHub] nifi pull request #2667: NIFI-5134 Explicitly requesting UGI to relogin befo...
GitHub user jtstorck opened a pull request:
https://github.com/apache/nifi/pull/2667
NIFI-5134 Explicitly requesting UGI to relogin before attempting to g…
…et a DB connection in HiveConnectionPool
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtstorck/nifi NIFI-5134
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2667.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2667
----
commit b0779545526205c475babc23931e92d177ad556d
Author: Jeff Storck <jt...@...>
Date: 2018-04-30T14:39:12Z
NIFI-5134 Explicitly requesting UGI to relogin before attempting to get a DB connection in HiveConnectionPool
----
---
[GitHub] nifi issue #2667: NIFI-5134 Explicitly requesting UGI to relogin before atte...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2667
+1 LGTM, looks like it will work like a barrier sync, the first one in will relogin if necessary, the rest will no-op, which means there won't be a race condition / threading issue when some of the threads call doAs. Thanks for the improvement! Merging to master
---
[GitHub] nifi pull request #2667: NIFI-5134 Explicitly requesting UGI to relogin befo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2667
---
[GitHub] nifi issue #2667: NIFI-5134 Explicitly requesting UGI to relogin before atte...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on the issue:
https://github.com/apache/nifi/pull/2667
@mattyb149, @markap14, would you please review this PR?
---