You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "humkum (via GitHub)" <gi...@apache.org> on 2023/10/10 01:50:31 UTC

Re: [PR] [ISSUE #7087] fix:consumer offset compatible problem caused by LmqConsumerOffsetManager [rocketmq]

humkum commented on code in PR #7090:
URL: https://github.com/apache/rocketmq/pull/7090#discussion_r1351162453


##########
broker/src/main/java/org/apache/rocketmq/broker/offset/LmqConsumerOffsetManager.java:
##########
@@ -36,6 +40,92 @@ public LmqConsumerOffsetManager(BrokerController brokerController) {
         super(brokerController);
     }
 
+    @Override
+    public boolean load() {

Review Comment:
   Compatibility logic can not remove to parent class, because it involves many different implementation methods, such as configFilePath, which can not obtain in parent class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org