You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sis.apache.org by de...@apache.org on 2020/12/17 17:18:07 UTC
svn commit: r1884563 [2/4] - in /sis/ip-review: ./ rev/01091/ rev/01094/
rev/01096/ rev/01097/ rev/01188/ rev/05052/ rev/05999/ rev/06057/
rev/06067/ rev/06068/ rev/06410/ rev/10796/ rev/11086/ rev/12288/
rev/17452/ rev/20874/ rev/20883/ rev/24476/
Added: sis/ip-review/rev/01096/MouseReshapeTracker.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/01096/MouseReshapeTracker.xhtml?rev=1884563&view=auto
==============================================================================
--- sis/ip-review/rev/01096/MouseReshapeTracker.xhtml (added)
+++ sis/ip-review/rev/01096/MouseReshapeTracker.xhtml Thu Dec 17 17:18:06 2020
@@ -0,0 +1,426 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>MouseReshapeTracker changes for revisions 1091:1096</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>MouseReshapeTracker changes for revisions 1091:1096</h1>
+
+ <p>Mostly reformatting, maybe done by some automatic tools.
+ The reformatting does not apply to Apache SIS since the code has been reformatted again.
+ Contains also a typo fix (<code>isDraging</code> renamed <code>isDragging</code>),
+ but that typo was already identified in a "TODO" comment.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r1091:1096 https://svn.osgeo.org/geotools/trunk/modules/extension/widgets-swing/src/main/java/org/geotools/gui/swing/MouseReshapeTracker.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 1091</th><th>Revision 1096</th></tr>
+<tr><td><pre>* }
+* </pre></blockquote>
+*
+* @version 1.0
+* @author Martin Desruisseaux
+*/</pre></td>
+<td><pre>* }
+* </pre></blockquote>
+*
+<span class="add">* $Id: MouseReshapeTracker.java,v 1.3 2002/07/15 15:50:34 loxnard Exp $</span>
+* @version 1.0
+* @author Martin Desruisseaux
+*/</pre></td></tr>
+<tr><td><pre> * Indicates if the user is currently dragging the rectangle.
+ * For this field to become <code>true</code>, the mouse must
+ * have been over the rectangle as the user pressed the mouse button.
+<span class="del"> * TODO: Replace all occurrences of "isDraging" with "isDragging".</span>
+ */
+<span class="del">private transient boolean isDraging;</span>
+
+/**
+ * Indicates which edges the user is currently adjusting with the mouse.</pre></td>
+<td><pre> * Indicates if the user is currently dragging the rectangle.
+ * For this field to become <code>true</code>, the mouse must
+ * have been over the rectangle as the user pressed the mouse button.
+ */
+<span class="add">private transient boolean isDragging;</span>
+
+/**
+ * Indicates which edges the user is currently adjusting with the mouse.</pre></td></tr>
+<tr><td><pre> * in order to finish the construction of certain
+ * fields.
+ */
+<span class="del">private void readObject(final ObjectInputStream in) throws IOException, ClassNotFoundException {</span>
+ drawnShape=logicalShape;
+ update();
+}</pre></td>
+<td><pre> * in order to finish the construction of certain
+ * fields.
+ */
+<span class="add">private void readObject(final ObjectInputStream in) throws IOException,</span>
+<span class="add"> ClassNotFoundException {</span>
+ drawnShape=logicalShape;
+ update();
+}</pre></td></tr>
+<tr><td><pre> tmp.x = (i&1)==0 ? drawnShape.getMinX() : drawnShape.getMaxX();
+ tmp.y = (i&2)==0 ? drawnShape.getMinY() : drawnShape.getMaxY();
+ transform.transform(tmp, tmp);
+<span class="del"> if (tmp.x<xmin) xmin=tmp.x;</span>
+<span class="del"> if (tmp.x>xmax) xmax=tmp.x;</span>
+<span class="del"> if (tmp.y<ymin) ymin=tmp.y;</span>
+<span class="del"> if (tmp.y>ymax) ymax=tmp.y;</span>
+}
+x = (int) Math.floor(xmin) -1;
+y = (int) Math.floor(ymin) -1;
+width = (int) Math.ceil (xmax-xmin) +2;</pre></td>
+<td><pre> tmp.x = (i&1)==0 ? drawnShape.getMinX() : drawnShape.getMaxX();
+ tmp.y = (i&2)==0 ? drawnShape.getMinY() : drawnShape.getMaxY();
+ transform.transform(tmp, tmp);
+<span class="add"> if (tmp.x < xmin) {</span>
+<span class="add"> xmin = tmp.x;</span>
+}
+<span class="add"> if (tmp.x > xmax) {</span>
+<span class="add"> xmax = tmp.x;</span>
+<span class="add"> }</span>
+<span class="add"> if (tmp.y < ymin) {</span>
+<span class="add"> ymin = tmp.y;</span>
+<span class="add"> }</span>
+<span class="add"> if (tmp.y > ymax) {</span>
+<span class="add"> ymax = tmp.y;</span>
+<span class="add"> }</span>
+<span class="add">}</span>
+x = (int) Math.floor(xmin) -1;
+y = (int) Math.floor(ymin) -1;
+width = (int) Math.ceil (xmax-xmin) +2;</pre></td></tr>
+<tr><td><pre> * {@link #setClipMinMax setClipMinMax(...)} rather than
+ * <code>setClip(...)</code>.
+ */
+<span class="del">public final void setClip(final double x, final double y, final double width, final double height) {</span>
+ setClipMinMax(x, x+width, y, y+height);
+}</pre></td>
+<td><pre> * {@link #setClipMinMax setClipMinMax(...)} rather than
+ * <code>setClip(...)</code>.
+ */
+<span class="add">public final void setClip(final double x, final double y, final double width,</span>
+<span class="add"> final double height) {</span>
+ setClipMinMax(x, x+width, y, y+height);
+}</pre></td></tr>
+<tr><td><pre> final double tmp=ymin;
+ ymin=ymax; ymax=tmp;
+ }
+<span class="del"> if (!Double.isNaN(xmin)) this.xmin=xmin;</span>
+<span class="del"> if (!Double.isNaN(xmax)) this.xmax=xmax;</span>
+<span class="del"> if (!Double.isNaN(ymin)) this.ymin=ymin;</span>
+<span class="del"> if (!Double.isNaN(ymax)) this.ymax=ymax;</span>
+<span class="del"> setFrame(logicalShape.getX(), logicalShape.getY(), logicalShape.getWidth(), logicalShape.getHeight());</span>
+}
+
+/**
+ * Method called automatically when a change in the clip is required.</pre></td>
+<td><pre> final double tmp=ymin;
+ ymin=ymax; ymax=tmp;
+ }
+<span class="add"> if (!Double.isNaN(xmin)) {</span>
+<span class="add"> this.xmin = xmin;</span>
+}
+<span class="add"> if (!Double.isNaN(xmax)) {</span>
+<span class="add"> this.xmax = xmax;</span>
+<span class="add"> }</span>
+<span class="add"> if (!Double.isNaN(ymin)) {</span>
+<span class="add"> this.ymin = ymin;</span>
+<span class="add"> }</span>
+<span class="add"> if (!Double.isNaN(ymax)) {</span>
+<span class="add"> this.ymax = ymax;</span>
+<span class="add"> }</span>
+<span class="add"> setFrame(logicalShape.getX(), logicalShape.getY(), logicalShape.getWidth(),</span>
+<span class="add"> logicalShape.getHeight());</span>
+<span class="add">}</span>
+
+/**
+ * Method called automatically when a change in the clip is required.</pre></td></tr>
+<tr><td><pre> */
+public void setAdjustable(int side, final boolean adjustable) {
+ side=convertSwingConstant(side);
+<span class="del"> if (adjustable) adjustableSides |= side;</span>
+<span class="del"> else adjustableSides &= ~side;</span>
+}
+
+/*
+ * Converts a Swing edge constant to system used by this package.</pre></td>
+<td><pre> */
+public void setAdjustable(int side, final boolean adjustable) {
+ side=convertSwingConstant(side);
+<span class="add"> if (adjustable) {</span>
+<span class="add"> adjustableSides |= side;</span>
+}
+<span class="add"> else {</span>
+<span class="add"> adjustableSides &= ~side;</span>
+<span class="add"> }</span>
+<span class="add">}</span>
+
+/*
+ * Converts a Swing edge constant to system used by this package.</pre></td></tr>
+<tr><td><pre> * one of its edges, and adjusts the mouse pointer icon accordingly.
+ */
+public void mouseMoved(final MouseEvent event) {
+<span class="del"> if (!isDraging) {</span>
+ final Component source=event.getComponent();
+ if (source!=null) {
+ int x=event.getX(); tmp.x=x;</pre></td>
+<td><pre> * one of its edges, and adjusts the mouse pointer icon accordingly.
+ */
+public void mouseMoved(final MouseEvent event) {
+<span class="add"> if (!isDragging) {</span>
+ final Component source=event.getComponent();
+ if (source!=null) {
+ int x=event.getX(); tmp.x=x;</pre></td></tr>
+<tr><td><pre> */
+final int old=adjustingSides;
+adjustingSides=0;
+<span class="del">if (Math.abs(x-=this.x) <=RESIZE_POS) adjustingSides |= WEST;</span>
+<span class="del">if (Math.abs(y-=this.y) <=RESIZE_POS) adjustingSides |= NORTH;</span>
+<span class="del">if (Math.abs(x- this.width) <=RESIZE_POS) adjustingSides |= EAST;</span>
+<span class="del">if (Math.abs(y- this.height)<=RESIZE_POS) adjustingSides |= SOUTH;</span>
+
+adjustingSides &= adjustableSides;
+if (adjustingSides!=old || mouseOverRectChanged) {</pre></td>
+<td><pre> */
+final int old=adjustingSides;
+adjustingSides=0;
+<span class="add">if (Math.abs(x -= this.x)<=RESIZE_POS){</span>
+<span class="add"> adjustingSides |= WEST;</span>
+<span class="add">}</span>
+<span class="add">if (Math.abs(y -= this.y)<=RESIZE_POS){</span>
+<span class="add"> adjustingSides |= NORTH;</span>
+<span class="add">}</span>
+<span class="add">if (Math.abs(x - this.width)<=RESIZE_POS) {</span>
+<span class="add"> adjustingSides |= EAST;</span>
+<span class="add">}</span>
+<span class="add">if (Math.abs(y - this.height)<=RESIZE_POS) {</span>
+<span class="add"> adjustingSides |= SOUTH;</span>
+<span class="add">}</span>
+
+adjustingSides &= adjustableSides;
+if (adjustingSides!=old || mouseOverRectChanged) {</pre></td></tr>
+<tr><td><pre> }
+}
+if (mouseOverRectChanged) {
+<span class="del"> // Ajouter et retirer des 'listeners' marchait bien, mais avait</span>
+<span class="del"> // l'inconvénient de changer l'ordre des 'listeners'. Ca causait</span>
+<span class="del"> // problème lorsque cet ordre était important.</span>
+
+ //source.addMouseListener(this);
+ this.mouseOverRect=mouseOverRect;</pre></td>
+<td><pre> }
+}
+if (mouseOverRectChanged) {
+<span class="add"> // Adding and removing listeners worked well, but had</span>
+<span class="add"> // the disadvantage of changing the order of the</span>
+<span class="add"> // listeners. This caused problems when the order was</span>
+<span class="add"> // important.</span>
+
+ //source.addMouseListener(this);
+ this.mouseOverRect=mouseOverRect;</pre></td></tr>
+<tr><td><pre> if (drawnShape.contains(transform.inverseTransform(tmp,tmp))) {
+ mouseDX = tmp.x-drawnShape.getX();
+ mouseDY = tmp.y-drawnShape.getY();
+<span class="del"> isDraging=true;</span>
+ e.consume();
+ }
+} catch (NoninvertibleTransformException exception) {</pre></td>
+<td><pre> if (drawnShape.contains(transform.inverseTransform(tmp,tmp))) {
+ mouseDX = tmp.x-drawnShape.getX();
+ mouseDY = tmp.y-drawnShape.getY();
+<span class="add"> isDragging = true;</span>
+ e.consume();
+ }
+} catch (NoninvertibleTransformException exception) {</pre></td></tr>
+<tr><td><pre>/**
+ * Method called automatically during mouse drags. The default
+ * implementation applies the mouse movement to the rectangle and notifies
+<span class="del"> * the component where the event which it needs to redraw, at least in part,</span>
+<span class="del"> * came from.</span>
+ */
+public void mouseDragged(final MouseEvent e) {
+<span class="del"> if (isDraging) {</span>
+ final int adjustingLogicalSides=this.adjustingLogicalSides;
+ final Component source=e.getComponent();
+ if (source!=null) try {</pre></td>
+<td><pre>/**
+ * Method called automatically during mouse drags. The default
+ * implementation applies the mouse movement to the rectangle and notifies
+<span class="add"> * the component where the event which it needs to redraw, at least in</span>
+<span class="add"> * part, came from.</span>
+ */
+public void mouseDragged(final MouseEvent e) {
+<span class="add"> if (isDragging) {</span>
+ final int adjustingLogicalSides=this.adjustingLogicalSides;
+ final Component source=e.getComponent();
+ if (source!=null) try {</pre></td></tr>
+<tr><td><pre> */
+switch (adjustingLogicalSides & (EAST|WEST)) {
+ case WEST: {
+<span class="del"> if (x0<xmin) x0=xmin;</span>
+ dx += drawnShape.getX()-x0;
+ if (!(dx>0)) {
+ dx=drawnShape.getWidth();</pre></td>
+<td><pre> */
+switch (adjustingLogicalSides & (EAST|WEST)) {
+ case WEST: {
+<span class="add"> if (x0 < xmin) {</span>
+<span class="add"> x0 = xmin;</span>
+<span class="add"> }</span>
+ dx += drawnShape.getX()-x0;
+ if (!(dx>0)) {
+ dx=drawnShape.getWidth();</pre></td></tr>
+<tr><td><pre>case EAST: {
+ dx += x0 - (x0=drawnShape.getX());
+ final double limit=xmax-x0;
+<span class="del"> if (dx>limit) dx=limit;</span>
+ if (!(dx>0)) {
+ dx=drawnShape.getWidth();
+ x0=drawnShape.getX();</pre></td>
+<td><pre>case EAST: {
+ dx += x0 - (x0=drawnShape.getX());
+ final double limit=xmax-x0;
+<span class="add"> if (dx > limit) {</span>
+<span class="add"> dx = limit;</span>
+<span class="add"> }</span>
+ if (!(dx>0)) {
+ dx=drawnShape.getWidth();
+ x0=drawnShape.getX();</pre></td></tr>
+<tr><td><pre>}
+switch (adjustingLogicalSides & (NORTH|SOUTH)) {
+ case NORTH: {
+<span class="del"> if (y0<ymin) y0=ymin;</span>
+ dy += drawnShape.getY()-y0;
+ if (!(dy>0)) {
+ dy=drawnShape.getHeight();</pre></td>
+<td><pre>}
+switch (adjustingLogicalSides & (NORTH|SOUTH)) {
+ case NORTH: {
+<span class="add"> if (y0 < ymin) {</span>
+<span class="add"> y0=ymin;</span>
+<span class="add"> }</span>
+ dy += drawnShape.getY()-y0;
+ if (!(dy>0)) {
+ dy=drawnShape.getHeight();</pre></td></tr>
+<tr><td><pre> /*
+ * Adjustment for special cases.
+ */
+<span class="del"> if ((adjustingLogicalSides & EAST )!=0) mouseDX += (drawnShape.getWidth() -oldWidth);</span>
+<span class="del"> if ((adjustingLogicalSides & SOUTH)!=0) mouseDY += (drawnShape.getHeight()-oldHeight);</span>
+} catch (NoninvertibleTransformException exception) {
+ // Ignore.
+}</pre></td>
+<td><pre> /*
+ * Adjustment for special cases.
+ */
+<span class="add"> if ((adjustingLogicalSides & EAST) != 0) {</span>
+<span class="add"> mouseDX += (drawnShape.getWidth() - oldWidth);</span>
+<span class="add"> }</span>
+<span class="add"> if ((adjustingLogicalSides & SOUTH) != 0) {</span>
+<span class="add"> mouseDY += (drawnShape.getHeight() - oldHeight);</span>
+<span class="add"> }</span>
+} catch (NoninvertibleTransformException exception) {
+ // Ignore.
+}</pre></td></tr>
+<tr><td><pre> * that the changes are finished.
+ */
+public void mouseReleased(final MouseEvent event) {
+<span class="del"> if (isDraging && (event.getModifiers() & MouseEvent.BUTTON1_MASK)!=0) {</span>
+<span class="del"> isDraging=false;</span>
+ final Component source=event.getComponent();
+ try {
+ tmp.x=event.getX();</pre></td>
+<td><pre> * that the changes are finished.
+ */
+public void mouseReleased(final MouseEvent event) {
+<span class="add"> if (isDragging && (event.getModifiers() & MouseEvent.BUTTON1_MASK) != 0) {</span>
+<span class="add"> isDragging = false;</span>
+ final Component source=event.getComponent();
+ try {
+ tmp.x=event.getX();</pre></td></tr>
+<tr><td><pre> if (!mouseOverRect && source!=null) source.setCursor(null);
+ event.consume();
+} catch (NoninvertibleTransformException exception) {
+<span class="del"> // Ignore cette exception.</span>
+} try {
+<span class="del"> // Il faut que 'isDraging=false'.</span>
+ fireStateChanged();
+} catch (RuntimeException exception) {
+ ExceptionMonitor.show(source, exception);</pre></td>
+<td><pre> if (!mouseOverRect && source!=null) source.setCursor(null);
+ event.consume();
+} catch (NoninvertibleTransformException exception) {
+<span class="add"> // Ignore this exception.</span>
+} try {
+<span class="add"> // It is essential that 'isDragging=false'.</span>
+ fireStateChanged();
+} catch (RuntimeException exception) {
+ ExceptionMonitor.show(source, exception);</pre></td></tr>
+<tr><td><pre> * size of the visor has changed.
+ */
+private void fireStateWillChange() {
+<span class="del"> stateWillChange(isDraging);</span>
+}
+
+/**</pre></td>
+<td><pre> * size of the visor has changed.
+ */
+private void fireStateWillChange() {
+<span class="add"> stateWillChange(isDragging);</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> */
+private void fireStateChanged() {
+ updateEditors();
+<span class="del"> stateChanged(isDraging);</span>
+}
+
+/**</pre></td>
+<td><pre> */
+private void fireStateChanged() {
+ updateEditors();
+<span class="add"> stateChanged(isDragging);</span>
+}
+
+/**</pre></td></tr>
+<tr><td><pre> * but it will do because it is unlikely that we will ever add more
+ * than 4 editors.
+ */
+<span class="del">final Control control=new Control(editor, (format instanceof DateFormat), convertSwingConstant(side), toRepaint);</span>
+if (editors==null) {
+ editors = new Control[1];
+} else {</pre></td>
+<td><pre> * but it will do because it is unlikely that we will ever add more
+ * than 4 editors.
+ */
+<span class="add">final Control control = new Control(editor, (format instanceof DateFormat),</span>
+<span class="add"> convertSwingConstant(side), toRepaint);</span>
+if (editors==null) {
+ editors = new Control[1];
+} else {</pre></td></tr>
+<tr><td><pre> * @throws IllegalArgumentException if <code>axis</code>
+ * isn't one of the valid codes.
+ */
+<span class="del">public void setEditorsSynchronized(final int axis, final boolean state) throws IllegalArgumentException {</span>
+ switch (axis) {
+ case SwingConstants.HORIZONTAL: synchronizeX=state; break;
+ case SwingConstants.VERTICAL: synchronizeY=state; break;</pre></td>
+<td><pre> * @throws IllegalArgumentException if <code>axis</code>
+ * isn't one of the valid codes.
+ */
+<span class="add">public void setEditorsSynchronized(final int axis, final boolean state)</span>
+<span class="add"> throws IllegalArgumentException {</span>
+ switch (axis) {
+ case SwingConstants.HORIZONTAL: synchronizeX=state; break;
+ case SwingConstants.VERTICAL: synchronizeY=state; break;</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/01097/ExceptionMonitor.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/01097/ExceptionMonitor.xhtml?rev=1884563&view=auto
==============================================================================
--- sis/ip-review/rev/01097/ExceptionMonitor.xhtml (added)
+++ sis/ip-review/rev/01097/ExceptionMonitor.xhtml Thu Dec 17 17:18:06 2020
@@ -0,0 +1,125 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>ExceptionMonitor changes for revisions 1090:1097</title>
+ <style type="text/css" media="all">
+ @import url("../../reports.css");
+ </style>
+ </head>
+ <body>
+ <div>
+ <h1>ExceptionMonitor changes for revisions 1090:1097</h1>
+
+ <p>Reformatting only, maybe done by some automatic tools.
+ Does not apply to Apache SIS since the code has been reformatted again.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r1090:1097 https://svn.osgeo.org/geotools/trunk/modules/extension/widgets-swing/src/main/java/org/geotools/gui/swing/ExceptionMonitor.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 1090</th><th>Revision 1097</th></tr>
+<tr><td><pre>* <i>Swing</i> component. The standard {@link java.lang.Exception} class
+* contains methods which write the exception to the error console.
+* This <code>ExceptionMonitor</code> class adds static methods which make
+<span class="del">* the message, and eventually the exception trace, appear in a</span>
+<span class="del">* viewer component.</span>
+*
+* <p>&nbsp;</p>
+* <p align="center"><img src="doc-files/ExceptionMonitor.png"></p>
+* <p>&nbsp;</p>
+*
+* @version 1.0
+* @author Martin Desruisseaux
+*/</pre></td>
+<td><pre>* <i>Swing</i> component. The standard {@link java.lang.Exception} class
+* contains methods which write the exception to the error console.
+* This <code>ExceptionMonitor</code> class adds static methods which make
+<span class="add">* the message, and eventually the exception trace, appear in a viewer</span>
+<span class="add">* component.</span>
+*
+* <p>&nbsp;</p>
+* <p align="center"><img src="doc-files/ExceptionMonitor.png"></p>
+* <p>&nbsp;</p>
+*
+<span class="add">* $Id: ExceptionMonitor.java,v 1.3 2002/07/15 15:52:38 loxnard Exp $</span>
+* @version 1.0
+* @author Martin Desruisseaux
+*/</pre></td></tr>
+<tr><td><pre> * transform, default colour, etc...)
+ * @param widgetBounds Size of the trace which was being drawn.
+ */
+<span class="del">public static void paintStackTrace(final Graphics2D graphics, final Rectangle widgetBounds, final Throwable exception) {</span>
+ /*
+ * Obtains the exception trace in the form of a character chain.
+ * The carriage returns in this chain can be "\r", "\n" or "r\n".</pre></td>
+<td><pre> * transform, default colour, etc...)
+ * @param widgetBounds Size of the trace which was being drawn.
+ */
+<span class="add">public static void paintStackTrace(final Graphics2D graphics, final Rectangle widgetBounds,</span>
+<span class="add"> final Throwable exception) {</span>
+ /*
+ * Obtains the exception trace in the form of a character chain.
+ * The carriage returns in this chain can be "\r", "\n" or "r\n".</pre></td></tr>
+<tr><td><pre>* Class in charge of displaying any exception messages and eventually
+* their traces. The message will appear in a dialog box or in an
+* internal window, depending on the parent.
+<span class="del">* <strong>Note:</strong> All methods in this class must be called in the same</span>
+<span class="del">* thread as the <i>Swing</i> thread.</span>
+*
+* @version 1.0
+* @author Martin Desruisseaux</pre></td>
+<td><pre>* Class in charge of displaying any exception messages and eventually
+* their traces. The message will appear in a dialog box or in an
+* internal window, depending on the parent.
+<span class="add">* <strong>Note:</strong> All methods in this class must be called in the</span>
+<span class="add">* same thread as the <i>Swing</i> thread.</span>
+*
+* @version 1.0
+* @author Martin Desruisseaux</pre></td></tr>
+<tr><td><pre>textArea.setWrapStyleWord(true);
+textArea.setBackground(null);
+textArea.setBorder(null); // Certain L&Fs have a border.
+/**
+ * Constructs the rest of the dialog box. The title bar will
+ * contain the name of the exception class.</pre></td>
+<td><pre>textArea.setWrapStyleWord(true);
+textArea.setBackground(null);
+textArea.setBorder(null); // Certain L&Fs have a border.
+<span class="add"></span>
+/**
+ * Constructs the rest of the dialog box. The title bar will
+ * contain the name of the exception class.</pre></td></tr>
+<tr><td><pre>JComponent traceComponent=null;
+for (Throwable cause = exception;
+ cause != null;
+<span class="del"> cause = cause.getCause())</span>
+<span class="del">{</span>
+ final JTextArea text=new JTextArea(1, WIDTH);
+ text.setTabSize(4);
+ text.setText(printStackTrace(cause));</pre></td>
+<td><pre>JComponent traceComponent=null;
+for (Throwable cause = exception;
+ cause != null;
+<span class="add">cause = cause.getCause()) {</span>
+ final JTextArea text=new JTextArea(1, WIDTH);
+ text.setTabSize(4);
+ text.setText(printStackTrace(cause));</pre></td></tr>
+<tr><td><pre>if (traceComponent!=null) {
+ if (!(traceComponent instanceof JTabbedPane)) {
+ String classname = Utilities.getShortClassName(exception);
+<span class="del"> JTabbedPane tabs = new JTabbedPane(JTabbedPane.TOP, JTabbedPane.SCROLL_TAB_LAYOUT);</span>
+ tabs.addTab(classname, traceComponent);
+ traceComponent = tabs;
+ }</pre></td>
+<td><pre>if (traceComponent!=null) {
+ if (!(traceComponent instanceof JTabbedPane)) {
+ String classname = Utilities.getShortClassName(exception);
+<span class="add"> JTabbedPane tabs = new JTabbedPane(JTabbedPane.TOP,</span>
+<span class="add"> JTabbedPane.SCROLL_TAB_LAYOUT);</span>
+ tabs.addTab(classname, traceComponent);
+ traceComponent = tabs;
+ }</pre></td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/01097/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/01097/HEADER.html?rev=1884563&view=auto
==============================================================================
--- sis/ip-review/rev/01097/HEADER.html (added)
+++ sis/ip-review/rev/01097/HEADER.html Thu Dec 17 17:18:06 2020
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>Revision 1097</title>
+ </head>
+ <body>
+ <div>
+ <h1>Revision 1097</h1>
+<table>
+ <tr><td><b>Author:</b></td><td>loxnard</td></tr>
+ <tr><td><b>Date:</b></td><td>2002-07-15</td></tr>
+ <tr><td><b>Message:</b></td><td>Updated Javadocs</td></tr>
+</table>
+ </div>
+ </body>
+</html>
Added: sis/ip-review/rev/01188/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/01188/HEADER.html?rev=1884563&view=auto
==============================================================================
--- sis/ip-review/rev/01188/HEADER.html (added)
+++ sis/ip-review/rev/01188/HEADER.html Thu Dec 17 17:18:06 2020
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+ <head>
+ <meta charset="UTF-8"/>
+ <title>Revision 1188</title>
+ </head>
+ <body>
+ <div>
+ <h1>Revision 1188</h1>
+<table>
+ <tr><td><b>Author:</b></td><td>jmacgill</td></tr>
+ <tr><td><b>Date:</b></td><td>2002-07-22</td></tr>
+ <tr><td><b>Message:</b></td><td>made setVisibableArea non final for now as MapPane needs to use it.</td></tr>
+</table>
+ </div>
+ </body>
+</html>