[GitHub] [superset] kgabryje commented on a change in pull request #18216: fix(explore): Pie chart label formatting when series is temporal

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #18216:
URL: https://github.com/apache/superset/pull/18216#discussion_r794538978



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
##########
@@ -88,9 +88,6 @@ export function formatSeriesName(
   if (name === undefined || name === null) {
     return NULL_STRING;
   }
-  if (typeof name === 'number') {

Review comment:
       Yep, just like Ville said :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org