You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/12 14:02:47 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #8437: ARROW-10263: [C++][Compute] Improve variance kernel numerical stability

cyb70289 commented on a change in pull request #8437:
URL: https://github.com/apache/arrow/pull/8437#discussion_r503317889



##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -1070,22 +1065,39 @@ TEST_F(TestVarStdKernelStability, Basics) {
   VarianceOptions options{1};  // ddof = 1
   this->AssertVarStdIs("[100000004, 100000007, 100000013, 100000016]", options, 30.0);
   this->AssertVarStdIs("[1000000004, 1000000007, 1000000013, 1000000016]", options, 30.0);
+
+#ifndef __MINGW32__  // MinGW has precision issues

Review comment:
       This test failed on mingw 32 community CI. And I see similar comments in decimal unit test.
   https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/decimal_test.cc#L695
   
   I didn't tested it on my side. Maybe I can start a 32bit VM to check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org