[GitHub] [dolphinscheduler] rickchengx commented on a diff in pull request #11292: [Improvement-11291][sql] Improvement the log output while executing multiple sql statements

[GitBox <gi...@apache.org>]

rickchengx commented on code in PR #11292:
URL: https://github.com/apache/dolphinscheduler/pull/11292#discussion_r940866968


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -302,6 +302,7 @@ private String executeQuery(Connection connection, SqlBinds sqlBinds, String han
     private String executeUpdate(Connection connection, List<SqlBinds> statementsBinds, String handlerType) throws Exception {
         int result = 0;
         for (SqlBinds sqlBind : statementsBinds) {
+            logger.info("{} statement execute update query, for sql: {}", handlerType, sqlBind.getSql());

Review Comment:
   > I don't understand why you did this...
   
   This log outputs the current sql statements while executing multiple sql statements so that user can understand which sql statement is executing. This is helpful when something goes wrong while executing multiple sql statements.
   
   The original log can only output the current sql statement if the sql type is `Mysql`, but cannot output the current sql statement if the sql type is `Hive`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org