You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 18:27:24 UTC

[GitHub] [airflow] pingzh edited a comment on pull request #21877: AIP-45 Remove dag parsing in airflow run local

pingzh edited a comment on pull request #21877:
URL: https://github.com/apache/airflow/pull/21877#issuecomment-1075448534


   > Hey @pingzh - can you address the comments and split this one into three PRs? The way we do it usually is that we have first PR that is with the first commit only and then second PR where we ask in the PR to only review the last commit. And there is a separate change with "increasing CI timeout" which also deserves to be separated.
   > 
   > This makes it easier to review and merge those changes later independently or one-after-another.
   
   @potiuk thanks a lot for reviewing the PR. i have rebased the main branch with bumping the CI timeout change.
   
   Good point, I have separated them into 2 PRs however we need to merge the second commit before the first commit.
   
   ---
   
   update
   
   on a second thoughts, these 2 commits are intertwined. How about let me merge those 2 commits into single one and add more description to the commit message and the PR description.
   
   let me know your thoughts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org