[GitHub] [maven-surefire] Tibor17 edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console

[GitBox <gi...@apache.org>]

Tibor17 edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498606747
 
 
   @cardil 
   The Apache guys made RunOrder OOP over-complicated. There is unnecessary objects like RunOrder and an array because we are parsing a string of one element to an array with one element, decomposition to object for (which inherently does not support Extensions because of the existence of ala enums) and composition from objects back to a string in `BooterSerializer`.
   I think the most simple approach is to use only call the constructor `public RunOrderParameters( String runOrder, File runStatisticsFile )` and not transforming string to `RunOrder`. Then the `RunOrderCalculator` would be as simple as an interpreter of the string, and the method `TestsToRun orderTestClasses( TestsToRun scannedClasses )` would be called in forked JVM. Then we are able to use SPI and the string is transparently moved from Maven process to the forked Surefire process just like that without any complexity.
   In your case the calculator would be SPI class with default constructor (one significant change).
   Everybody can specify own format and patter except those several default ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services