You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/07 10:04:21 UTC

[GitHub] [arrow-rs] alamb commented on issue #2837: Inconsistent Dyn Scalar Kernels

alamb commented on issue #2837:
URL: https://github.com/apache/arrow-rs/issues/2837#issuecomment-1271391847

   Renaming the kernels sounds good to me 👍 
   
   > I would therefore like to propose adding new [eq | lt_eq | ...]_dyn_primitive_scalar comparison kernels, and deprecating the old [eq | lt_eq | ...]_dyn_scalar kernels, before removing them in a future release.
   
   Would it be better to simply not have the `dyn_primitive_scalar` kernels and instead use docstrings or something else to show how to the kernels with primitives?
   
   Here is where @matthewmturner  and I cooked up the original API: https://github.com/apache/arrow-rs/pull/1074 which also gives some background on why we didn't go with the `T::Native` approach
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org