[jira] Commented: (MYFACES-304) FacesContext.getClientIdsWithMessages() fails to return null

["Grant Smith (JIRA)" <my...@incubator.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-304?page=comments#action_12315152 ] 

Grant Smith commented on MYFACES-304:
-------------------------------------

I modified ServletFacesContextImpl:

1. getClientIdsWithMessages() now returns an Iterator of a HashSet built from the _messageClientIds List (thus unique)
2. removed the code which stripped the null from the Iterator.

Please test before I close this  :)


> FacesContext.getClientIdsWithMessages() fails to return null
> ------------------------------------------------------------
>
>          Key: MYFACES-304
>          URL: http://issues.apache.org/jira/browse/MYFACES-304
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>     Reporter: Adam Winer
>     Assignee: Grant Smith

>
> If a global message is added to the FacesContext (clientId is null), then someone calls getClientIdsWithMessages(), the Iterator that is returned should include null.  It does not;  it does correctly do this on the RI.
> Also, from code inspection, it appears that getClientIdsWithMessages() will return a client ID twice if two messages are added against the same client ID.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira