You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/08/21 06:01:28 UTC

[GitHub] [airflow] potiuk opened a new pull request, #33572: Bump min-version for docker and docker-compose

potiuk opened a new pull request, #33572:
URL: https://github.com/apache/airflow/pull/33572

   It's been quite some time since we bumped min versions for docker and docker-compose for Breeze and there are already a few cases where it held us back from more efficiently using some newer docker or docker-compose features (for example in #33547). Also docker-compose v1 is sufficiently old an unmaintained, that it's about time to get rid of it and ask the users to migrate to docker-compose v2.
   
   The new min versions propose:
   
   * Docker: 23.0.0 released 2023-02-01 (6 months ago)
   * Docker Compose 2.14.0 release 2022-12-15 (8 months ago)
   
   Docker v1 is not supported any more and the users are directed to migrate to v2 to continue using Breeze.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33572:
URL: https://github.com/apache/airflow/pull/33572#issuecomment-1685751398

   OK. Seems that our CI's docker is too old :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33572:
URL: https://github.com/apache/airflow/pull/33572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33572:
URL: https://github.com/apache/airflow/pull/33572#issuecomment-1686316456

   So far so good:
   
   ![image](https://github.com/apache/airflow/assets/595491/bc766e2d-28d0-4ede-8c76-51abb1b8326d)
   
   I set-up the "min-versions" in CI that correspond to the min-versions we have in Breeze - this way we will see in CI if we introduce something not supported by those in most cases (since we are running almost all our breeze commands as part of the CI jobs of ours).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk closed pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #33572: Bump min-version for docker and docker-compose
URL: https://github.com/apache/airflow/pull/33572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33572:
URL: https://github.com/apache/airflow/pull/33572#issuecomment-1686290464

   Ok. We should have now docker and docker compose updated for our self-hosted runners. Let's see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33572:
URL: https://github.com/apache/airflow/pull/33572#issuecomment-1685856009

   But it looks like the version check works nicely BTW :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33572: Bump min-version for docker and docker-compose

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33572:
URL: https://github.com/apache/airflow/pull/33572#issuecomment-1686426306

   Looks great. Trying on public runners, just in case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org