You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/05/02 13:53:33 UTC

[GitHub] [nifi] markobean commented on a change in pull request #3442: NIFI-6225 Added alphabetical sort onto relationship lists for Connection dialog

markobean commented on a change in pull request #3442: NIFI-6225 Added alphabetical sort onto relationship lists for Connection dialog
URL: https://github.com/apache/nifi/pull/3442#discussion_r280428665
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection-configuration.js
 ##########
 @@ -102,7 +102,7 @@
                 initializeSourceProcessor(source).done(function (processor) {
                     if (!nfCommon.isEmpty(processor.relationships)) {
                         // populate the available connections
-                        $.each(processor.relationships, function (i, relationship) {
+                        $.each(processor.relationships.sort(), function (i, relationship) {
 
 Review comment:
   I agree with closing this PR, and re-working from ConnectionEntityMerger rather than covering it up in javascript.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services