You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "sramazzina (via GitHub)" <gi...@apache.org> on 2025/12/12 21:47:16 UTC

[PR] Fix #5225 (hop)

sramazzina opened a new pull request, #6194:
URL: https://github.com/apache/hop/pull/6194

   Fix #5225 - Cannot wire Workflow Executor results rows hop to next transform
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
   - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
   - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix #5225 (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #6194:
URL: https://github.com/apache/hop/pull/6194#issuecomment-3655768761

   Can we build an integration test for this behavior?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix #5225 (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #6194:
URL: https://github.com/apache/hop/pull/6194#issuecomment-3660801913

   Sounds good.  Thanks @sramazzina 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix #5225 (hop)

Posted by "sramazzina (via GitHub)" <gi...@apache.org>.
sramazzina commented on PR #6194:
URL: https://github.com/apache/hop/pull/6194#issuecomment-3660763444

   Hi @mattcasters the integration test has been added. The test checks for the correct receival of the execution result's rows stream out of the workflow executor transform. The piece that is missing is that we cannot test the interaction from within the GUI: workflow executor to next transform, the selection of the output and then the save that was the root of the problem for this issue. IMHO the PR can be merged now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix #5225 (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters merged PR #6194:
URL: https://github.com/apache/hop/pull/6194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix #5225 (hop)

Posted by "sramazzina (via GitHub)" <gi...@apache.org>.
sramazzina commented on PR #6194:
URL: https://github.com/apache/hop/pull/6194#issuecomment-3655781659

   Yes I agree I'll do that. My bad


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org