You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/30 16:49:53 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5795: Minor: fix docs build
alamb opened a new pull request, #5795:
URL: https://github.com/apache/arrow-datafusion/pull/5795
# Which issue does this PR close?
NA
# Rationale for this change
https://github.com/apache/arrow-datafusion/pull/5780 unfortunately broke the docs build (see https://github.com/apache/arrow-datafusion/actions/runs/4566861530/jobs/8059935571)
I think this is because @sanderson fixed the script to work on mac (it previously was broken) but that sadly broke it on linux.
# What changes are included in this PR?
Mess with `sed` command line
# Are these changes tested?
No -- will test 'live'
# Are there any user-facing changes?
Not really
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] sanderson commented on pull request #5795: Minor: fix docs build
Posted by "sanderson (via GitHub)" <gi...@apache.org>.
sanderson commented on PR #5795:
URL: https://github.com/apache/arrow-datafusion/pull/5795#issuecomment-1490626291
Oh, shoot! I meant to remove that. Sorry. Thanks for the fix @alamb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5795: Minor: fix docs build
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5795:
URL: https://github.com/apache/arrow-datafusion/pull/5795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5795: Minor: fix docs build
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5795:
URL: https://github.com/apache/arrow-datafusion/pull/5795#issuecomment-1490727247
>
Oh, shoot! I meant to remove that. Sorry. Thanks for the fix @alamb.
No worries -- I should have caught it in review 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5795: Minor: fix docs build
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5795:
URL: https://github.com/apache/arrow-datafusion/pull/5795#issuecomment-1490624626
I tested this locally on mac and in docker with linux and I think we are good now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org