You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/07/02 23:35:19 UTC

[kudu-CR] KUDU-2420: Support parallel java tests

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )

Change subject: KUDU-2420: Support parallel java tests
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@115
PS5, Line 115: a  un
extra space


http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:

http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@50
PS5, Line 50:   protected static final String TABLE_NAME =
Can we get rid of these hacks now, since there shouldn't be any conflicting tables?  No need to do it as part of this patch, I'm just curious.



-- 
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:35:19 +0000
Gerrit-HasComments: Yes