You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Carlos Santana (JIRA)" <ji...@apache.org> on 2013/10/16 21:43:42 UTC
[jira] [Assigned] (CB-5105) remove dead code for device.version
from native plugin source
[ https://issues.apache.org/jira/browse/CB-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Santana reassigned CB-5105:
----------------------------------
Assignee: (was: Carlos Santana)
> remove dead code for device.version from native plugin source
> -------------------------------------------------------------
>
> Key: CB-5105
> URL: https://issues.apache.org/jira/browse/CB-5105
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Device
> Affects Versions: 3.1.0
> Reporter: Marcel Kinard
> Priority: Minor
>
> The solution for CB-5085 (and related) is for device.js to set device.cordova using CORDOVA_JS_BUILD_LABEL from cordova.js, instead of having native code do that (usually with hardcoded values) and return it back from exec(). So once CB-5085 is fixed in this way, then any native code that computes device.version is dead. That dead code should be removed from cordova-plugin-device, if for no other reason than reducing confusion.
> The following platforms are affected: Android, BB10, WP8, Win8.
> iOS is doing something special, but doing it right, so don't make any changes to iOS.
--
This message was sent by Atlassian JIRA
(v6.1#6144)