You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/14 19:26:00 UTC
[jira] [Commented] (FLINK-7197) Missing call to
GraphAlgorithmWrappingBase#canMergeConfigurationWith()
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087854#comment-16087854 ]
ASF GitHub Bot commented on FLINK-7197:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4345
[FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
Fix for methods calling the incorrect super function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 7197_missing_call_to_can_merge_configuration_with
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4345
----
commit 31ecb4ffb74689a7a0b377a31b54ab2b205cb08a
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-07-14T19:23:29Z
[FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
Fix for methods calling the incorrect super function.
----
> Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
> ----------------------------------------------------------------------
>
> Key: FLINK-7197
> URL: https://issues.apache.org/jira/browse/FLINK-7197
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Greg Hogan
> Priority: Minor
>
> In flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateVertexValues.java :
> {code}
> protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase other) {
> super.mergeConfiguration(other);
> {code}
> GraphAlgorithmWrappingBase#canMergeConfigurationWith() should be called.
> There is similar issue in TranslateGraphIds.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)