You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2023/02/15 10:49:08 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #24177: Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent
linghengqian opened a new pull request, #24177:
URL: https://github.com/apache/shardingsphere/pull/24177
For #21347.
Changes proposed in this pull request:
- Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent.
- Adapt to the changes made by Seata 1.6.x. Refer to https://github.com/seata/seata/issues/5343#issuecomment-1431053066 .
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on pull request #24177: Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on PR #24177:
URL: https://github.com/apache/shardingsphere/pull/24177#issuecomment-1447811802
<img width="1233" alt="image" src="https://user-images.githubusercontent.com/19788130/221804365-1767d50c-3a89-44a8-b01f-137947b52253.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #24177: Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on PR #24177:
URL: https://github.com/apache/shardingsphere/pull/24177#issuecomment-1431141253
- Since Seata 1.4.2 carries cglib that is not compatible with JDK17, it will break class loading when using GraalVM Tracing Agent to execute related unit tests under JVM.
- 
- 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24177: Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24177:
URL: https://github.com/apache/shardingsphere/pull/24177#issuecomment-1431279678
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24177](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cf22f4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c202fe66495940dcd12bc7eba7f427d194c79642?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c202fe6) will **decrease** coverage by `0.02%`.
> The diff coverage is `30.00%`.
> :exclamation: Current head 8cf22f4 differs from pull request most recent head f897596. Consider uploading reports for the commit f897596 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24177 +/- ##
============================================
- Coverage 50.14% 50.13% -0.02%
Complexity 1579 1579
============================================
Files 3258 3258
Lines 53512 53513 +1
Branches 9853 9856 +3
============================================
- Hits 26834 26829 -5
- Misses 24321 24325 +4
- Partials 2357 2359 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ndler/query/ShowDatabaseDiscoveryRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dEYXRhYmFzZURpc2NvdmVyeVJ1bGVFeGVjdXRvci5qYXZh) | `78.57% <0.00%> (-1.43%)` | :arrow_down: |
| [...ore/ReadwriteSplittingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvUmVhZHdyaXRlU3BsaXR0aW5nRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...l/parser/core/ShardingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvU2hhcmRpbmdEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...jdbc/core/resultset/DatabaseMetaDataResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvamRiYy9jb3JlL3Jlc3VsdHNldC9EYXRhYmFzZU1ldGFEYXRhUmVzdWx0U2V0LmphdmE=) | `97.24% <ø> (ø)` | |
| [.../query/ShowShardingTableReferenceRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvU2hvd1NoYXJkaW5nVGFibGVSZWZlcmVuY2VSdWxlRXhlY3V0b3IuamF2YQ==) | `66.66% <50.00%> (ø)` | |
| [...dler/query/ShowReadwriteSplittingRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvcXVlcnkvU2hvd1JlYWR3cml0ZVNwbGl0dGluZ1J1bGVFeGVjdXRvci5qYXZh) | `95.00% <66.66%> (-2.44%)` | :arrow_down: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/24177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #24177: Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #24177:
URL: https://github.com/apache/shardingsphere/pull/24177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org