[GitHub] ThomasDelteil commented on a change in pull request #11332: [MXNET-558] Fix 'AttributeError: '_thread._local' object has no attribute 'value'' on distributed processing applications

[GitBox <gi...@apache.org>]

ThomasDelteil commented on a change in pull request #11332: [MXNET-558] Fix 'AttributeError: '_thread._local' object has no attribute 'value'' on distributed processing applications
URL: https://github.com/apache/incubator-mxnet/pull/11332#discussion_r196588693
 
 

 ##########
 File path: python/mxnet/symbol/symbol.py
 ##########
 @@ -2451,7 +2451,8 @@ def var(name, attr=None, shape=None, lr_mult=None, wd_mult=None, dtype=None,
     handle = SymbolHandle()
     check_call(_LIB.MXSymbolCreateVariable(c_str(name), ctypes.byref(handle)))
     ret = Symbol(handle)
-    attr = AttrScope._current.value.get(attr)
+    with AttrScope():
 
 Review comment:
   That logic is already included in the context 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services