You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by weand <gi...@git.apache.org> on 2017/02/23 22:37:17 UTC
[GitHub] zeppelin pull request #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm...
GitHub user weand opened a pull request:
https://github.com/apache/zeppelin/pull/2062
ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
### What is this PR for?
A common use case in LDAP/AD setup is the hierarchical structuring of
groups - a.k.a. adding groups to other groups. Such nesting groups can
help reduce the number of roles that need to be managed.
Current zeppelin realm implementations doesn't have support for looking
up memberships throughout nested group structures.
E.g. consider the following nested group scenario:
```
acme_employees
\__department_a
\__sub_department_x
```
User 'bob' is in Group 'sub_department_x'.
Notebook 'note1' has a Reader Role assignment for 'department_a' or
'acme_employees'.
Then access must be granted for 'bob' on 'note1'.
In AD enviroments this scenarios can be efficiently implemented using
the so called LDAP_MATCHING_RULE_IN_CHAIN operator
'1.2.840.113556.1.4.1941'.
This PR introduces a property 'groupSearchEnableMatchingRuleInChain' to
org.apache.zeppelin.realm.LdapRealm which defaults to false. If enabled,
all roles of potential nested group hierarchies will be resolved using
the LDAP_MATCHING_RULE_IN_CHAIN operator.
### What type of PR is it?
Improvement
### Todos
-
### What is the Jira issue?
[ZEPPELIN-2161]
### How should this be tested?
Set groupSearchEnableMatchingRuleInChain = true for the ldap realm.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n
* Is there breaking changes for older versions? n
* Does this needs documentation? y
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weand/zeppelin ZEPPELIN-2161
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2062.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2062
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Thanks @weand for improvmenet.
Have you turn on "Build Pushes" in travis-ci settings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Rebased and green now. Thanks for your help.
Would you mind merging that into branch-0.7 as well?
Regarding docu:
The LDAP Realm section in the docu [shiroauthentication.md](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap) only mentions LdapGroupRealm implementation. This change is related to the undocumented LdapRealm, which was introduced in 0.7.0.
Should we document two LDAP Realms, or should we mark the old one deprecated?
Because of that, I would prefer an separate Issue for the missing piece of documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2062
any idea why the build has failed? I don't get the error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
@weand So far, we have a section for LdapRealm in [shiroauthentication.md](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap).
> NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[CJ4Y6RZ]> but was:<2C[ADXZJ8N]>
> NotebookTest.testAuthorizationRoles:759 expected: but was:
This problem has been fixed in current master branch. Could you rebase or merge master and see if test passes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Can you update the doc (https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap) as well, so user reading http://zeppelin.apache.org/docs/0.7.0/security/shiroauthentication.html#ldap can leverage this feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2062
@prabhjyotsingh There isn't any documentation for org.apache.zeppelin.realm.LdapRealm yet.
@Leemoonsoo Any special reason why LdapRealm wasn't documented in 0.7.0 yet?
Can anyone help me why the build is failing. I don't see, why these tests now fail, they have no obvious reference to changes of this PR:
NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[CJ4Y6RZ]> but was:<2C[ADXZJ8N]>
NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2062
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Okay, LGTM.
Merge master and branch-0.7 if no further discussion.
Regarding documentation, if LdapGroupRealm and LdapRealm are superset/subset relation, we can mark one deprecated. If not, i think we should have document two LDAP Realms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---