You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Andras Katona via Review Board <no...@reviews.apache.org> on 2022/03/02 11:51:44 UTC
Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/
-----------------------------------------------------------
Review request for ranger and Ramesh Mani.
Bugs: RANGER-3231
https://issues.apache.org/jira/browse/RANGER-3231
Repository: ranger
Description
-------
kafka.security.auth.Authorizer has been deprecated since December 2019, and
it's removed in Apache Kafka 3.0
Diffs
-----
plugin-kafka/pom.xml d95f591fe
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
ranger-kafka-plugin-shim/pom.xml 3264138a8
ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
Diff: https://reviews.apache.org/r/73880/diff/1/
Testing
-------
unit tests executed via maven
related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
Thanks,
Andras Katona
Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/#review224258
-----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
Lines 257 (patched)
<https://reviews.apache.org/r/73880/#comment313132>
Can the clientAddress() be null?
- Ramesh Mani
On March 26, 2022, 10:54 a.m., Andras Katona wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73880/
> -----------------------------------------------------------
>
> (Updated March 26, 2022, 10:54 a.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-3231
> https://issues.apache.org/jira/browse/RANGER-3231
>
>
> Repository: ranger
>
>
> Description
> -------
>
> kafka.security.auth.Authorizer has been deprecated since December 2019, and
> it's removed in Apache Kafka 3.0
>
>
> Diffs
> -----
>
> plugin-kafka/pom.xml d95f591fe
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
> ranger-kafka-plugin-shim/pom.xml 3264138a8
> ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
>
>
> Diff: https://reviews.apache.org/r/73880/diff/3/
>
>
> Testing
> -------
>
> unit tests executed via maven
>
> related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
>
>
> Thanks,
>
> Andras Katona
>
>
Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/#review224260
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On April 6, 2022, 7:53 p.m., Andras Katona wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73880/
> -----------------------------------------------------------
>
> (Updated April 6, 2022, 7:53 p.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-3231
> https://issues.apache.org/jira/browse/RANGER-3231
>
>
> Repository: ranger
>
>
> Description
> -------
>
> kafka.security.auth.Authorizer has been deprecated since December 2019, and
> it's removed in Apache Kafka 3.0
>
>
> Diffs
> -----
>
> plugin-kafka/pom.xml d95f591fe
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
> ranger-kafka-plugin-shim/pom.xml 3264138a8
> ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
>
>
> Diff: https://reviews.apache.org/r/73880/diff/4/
>
>
> Testing
> -------
>
> unit tests executed via maven
>
> related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
>
>
> Thanks,
>
> Andras Katona
>
>
Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
Posted by Andras Katona via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/
-----------------------------------------------------------
(Updated April 6, 2022, 7:53 p.m.)
Review request for ranger and Ramesh Mani.
Changes
-------
null check
Bugs: RANGER-3231
https://issues.apache.org/jira/browse/RANGER-3231
Repository: ranger
Description
-------
kafka.security.auth.Authorizer has been deprecated since December 2019, and
it's removed in Apache Kafka 3.0
Diffs (updated)
-----
plugin-kafka/pom.xml d95f591fe
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
ranger-kafka-plugin-shim/pom.xml 3264138a8
ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
Diff: https://reviews.apache.org/r/73880/diff/4/
Changes: https://reviews.apache.org/r/73880/diff/3-4/
Testing
-------
unit tests executed via maven
related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
Thanks,
Andras Katona
Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
Posted by Andras Katona via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/
-----------------------------------------------------------
(Updated March 26, 2022, 10:54 a.m.)
Review request for ranger and Ramesh Mani.
Changes
-------
early return in case empty actions are received to authorize
Bugs: RANGER-3231
https://issues.apache.org/jira/browse/RANGER-3231
Repository: ranger
Description
-------
kafka.security.auth.Authorizer has been deprecated since December 2019, and
it's removed in Apache Kafka 3.0
Diffs (updated)
-----
plugin-kafka/pom.xml d95f591fe
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
ranger-kafka-plugin-shim/pom.xml 3264138a8
ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
Diff: https://reviews.apache.org/r/73880/diff/3/
Changes: https://reviews.apache.org/r/73880/diff/2-3/
Testing
-------
unit tests executed via maven
related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
Thanks,
Andras Katona
Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
Posted by Andras Katona via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/
-----------------------------------------------------------
(Updated March 8, 2022, 12:27 p.m.)
Review request for ranger and Ramesh Mani.
Changes
-------
logging fix for request context
Bugs: RANGER-3231
https://issues.apache.org/jira/browse/RANGER-3231
Repository: ranger
Description
-------
kafka.security.auth.Authorizer has been deprecated since December 2019, and
it's removed in Apache Kafka 3.0
Diffs (updated)
-----
plugin-kafka/pom.xml d95f591fe
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
ranger-kafka-plugin-shim/pom.xml 3264138a8
ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
Diff: https://reviews.apache.org/r/73880/diff/2/
Changes: https://reviews.apache.org/r/73880/diff/1-2/
Testing
-------
unit tests executed via maven
related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
Thanks,
Andras Katona
Re: Review Request 73880: RANGER-3231: Ranger-Kafka-Plugin implementing Kafka Authorizer from KIP-504
Posted by Andras Katona via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73880/#review224142
-----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
Line 156 (original), 255 (patched)
<https://reviews.apache.org/r/73880/#comment313071>
requestConext doesn't have a neat tostring
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
Lines 261 (patched)
<https://reviews.apache.org/r/73880/#comment313072>
log parts of the request context as it doesn't have a tostring
ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
Line 169 (original), 127 (patched)
<https://reviews.apache.org/r/73880/#comment313073>
log parts of the request context as it doesn't have a tostring
- Andras Katona
On March 2, 2022, 11:51 a.m., Andras Katona wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73880/
> -----------------------------------------------------------
>
> (Updated March 2, 2022, 11:51 a.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-3231
> https://issues.apache.org/jira/browse/RANGER-3231
>
>
> Repository: ranger
>
>
> Description
> -------
>
> kafka.security.auth.Authorizer has been deprecated since December 2019, and
> it's removed in Apache Kafka 3.0
>
>
> Diffs
> -----
>
> plugin-kafka/pom.xml d95f591fe
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 97a2f2ec7
> ranger-kafka-plugin-shim/pom.xml 3264138a8
> ranger-kafka-plugin-shim/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java b84b765c2
>
>
> Diff: https://reviews.apache.org/r/73880/diff/1/
>
>
> Testing
> -------
>
> unit tests executed via maven
>
> related PR: https://github.com/apache/ranger/pull/133 - currently executing checks, last time failed with unrelated compile error: missing dependency
>
>
> Thanks,
>
> Andras Katona
>
>