You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/11/13 13:15:26 UTC

[GitHub] [tinkerpop] vtslab commented on pull request #1308: TINKERPOP-2389 WIP: Authorization support in TinkerPop

vtslab commented on pull request #1308:
URL: https://github.com/apache/tinkerpop/pull/1308#issuecomment-726758273


   I just discovered from the code comments that SubgraphStrategy has an unusual implementation for concatenating two withStrategies() steps: the second one simply supersedes the first one instead of &&-ing the predicates of the two SubgraphStrategies as one would expect. I can confirm this behavior in gremlin console. 
   Now that we want to advocate the use of SubgraphStrategy for authorization, this behavior requires at least some lines and an example in the traversal ref docs. Personally, I would not object against modifying the semantics of SubgraphStrategy concatenation, thus introducing a breaking change. **What is your preference what to do and in what ticket/PR?** I have not checked yet whether &&-ing the predicates is easy to implement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org