You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "vipere (via GitHub)" <gi...@apache.org> on 2023/06/08 09:09:40 UTC
[GitHub] [arrow-adbc] vipere opened a new pull request, #744: fix(python/adbc_driver_manager): fix fetching queries with empty results
vipere opened a new pull request, #744:
URL: https://github.com/apache/arrow-adbc/pull/744
`fetchall` currently fails on queries that return no results.
The issue is `_reader.read_next_batch()` returns a batch with no rows which is not expected by the python code.
I've added a condition similar to the one in the [go driver](https://github.com/apache/arrow-adbc/blob/main/go/adbc/sqldriver/driver.go#L590).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #744: fix(python/adbc_driver_manager): fix fetching queries with empty results
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #744:
URL: https://github.com/apache/arrow-adbc/pull/744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #744: fix(python/adbc_driver_manager): fix fetching queries with empty results
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #744:
URL: https://github.com/apache/arrow-adbc/pull/744#issuecomment-1582500452
It is valid (even if strange) to have an empty batch. So maybe we should instead re-read until we get a non-empty batch here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org