You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/12/04 09:23:12 UTC
[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1171
[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit tests
Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:
multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.6-rate-limit-testfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1171
----
commit dcc66651c0a5f53fcd9395139dad147b4ac1ea09
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-12-04T08:17:03Z
rate-limit: increase JVM memory and enable fork mode for unit tests
Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to fix intermittent Jenkins failures
which look like:
multipleClientsCanAccessWithoutBlocking(org.apache.cloudstack.ratelimit.ApiRateLimitTest):
unable to create new native thread
(cherry picked from commit 421bc00cd6005d9e8484c6df46a3b84ff466afd2)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161921440
@remibergsma thanks, not sure why this happened again. This was supposed to be for 4.6, will recreate a new PR. I'm not sure on how to test it, it's just that Jenkins build sometimes fails (if you'd google you may see some old failures); this was mainly for 4.5 but I thought the config changes (the JAVA_OPTS and surefire config changes) might be useful for 4.6+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161922013
@remibergsma okay, I found what Github did in my case: when you select the second branch dropdown while create a PR it resets the first dropdown branch to master
Here's the 4.6 based PR https://github.com/apache/cloudstack/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161920716
@bhaisaab How can I help testing this? Also, your branch mentions 4.6 but the PR is made against master branch. Is that correct? Just checking ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---